Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor test_pyexpat.py to use unittest. #44780

Closed
jerryseutter mannequin opened this issue Mar 28, 2007 · 4 comments
Closed

Refactor test_pyexpat.py to use unittest. #44780

jerryseutter mannequin opened this issue Mar 28, 2007 · 4 comments
Labels
tests Tests in the Lib/test dir

Comments

@jerryseutter
Copy link
Mannequin

jerryseutter mannequin commented Mar 28, 2007

BPO 1690169
Files
  • refactor_test_pyexpat.patch: patch v1
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2007-03-28.23:35:01.000>
    created_at = <Date 2007-03-28.20:59:02.000>
    labels = ['tests']
    title = 'Refactor test_pyexpat.py to use unittest.'
    updated_at = <Date 2007-03-28.23:35:01.000>
    user = 'https://bugs.python.org/jerryseutter'

    bugs.python.org fields:

    activity = <Date 2007-03-28.23:35:01.000>
    actor = 'collinwinter'
    assignee = 'collinwinter'
    closed = True
    closed_date = None
    closer = None
    components = ['Tests']
    creation = <Date 2007-03-28.20:59:02.000>
    creator = 'jerry.seutter'
    dependencies = []
    files = ['7904']
    hgrepos = []
    issue_num = 1690169
    keywords = ['patch']
    message_count = 4.0
    messages = ['52316', '52317', '52318', '52319']
    nosy_count = 2.0
    nosy_names = ['collinwinter', 'jerry.seutter']
    pr_nums = []
    priority = 'normal'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue1690169'
    versions = ['Python 2.6']

    @jerryseutter
    Copy link
    Mannequin Author

    jerryseutter mannequin commented Mar 28, 2007

    This patch refactors test_pyexpat.py to use unittest. When this patch is applied, Lib/test/output/test_pyexpat can be removed.

    This patch combined with patch 1683397 and patch 1690164 makes Lib/test/output/xmltest redundant. It can be removed.

    @jerryseutter jerryseutter mannequin closed this as completed Mar 28, 2007
    @jerryseutter jerryseutter mannequin added the tests Tests in the Lib/test dir label Mar 28, 2007
    @jerryseutter jerryseutter mannequin closed this as completed Mar 28, 2007
    @jerryseutter jerryseutter mannequin added the tests Tests in the Lib/test dir label Mar 28, 2007
    @collinwinter
    Copy link
    Mannequin

    collinwinter mannequin commented Mar 28, 2007

    So do I need to apply this patch plus 1683397 and 1690164 at the same time?

    @jerryseutter
    Copy link
    Mannequin Author

    jerryseutter mannequin commented Mar 28, 2007

    It's up to you. If you patch one of them at a time, the xmltest unit test will be broken unless you regenerate the output file.

    If you apply all three of them at once, you can remove Lib/test/output/xmltest.

    @collinwinter
    Copy link
    Mannequin

    collinwinter mannequin commented Mar 28, 2007

    Applied as r54603. Thanks, Jerry!

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    tests Tests in the Lib/test dir
    Projects
    None yet
    Development

    No branches or pull requests

    0 participants