logging.handlers.SocketHandler.makeSocket() blocks app

[jtdeng]

BPO	1695948
Nosy	@vsajip

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/vsajip'
closed_at = <Date 2007-04-09.16:18:17.000>
created_at = <Date 2007-04-07.06:22:08.000>
labels = ['library']
title = 'logging.handlers.SocketHandler.makeSocket() blocks app'
updated_at = <Date 2007-04-09.16:18:17.000>
user = 'https://bugs.python.org/jtdeng'

bugs.python.org fields:

activity = <Date 2007-04-09.16:18:17.000>
actor = 'vinay.sajip'
assignee = 'vinay.sajip'
closed = True
closed_date = None
closer = None
components = ['Library (Lib)']
creation = <Date 2007-04-07.06:22:08.000>
creator = 'jtdeng'
dependencies = []
files = []
hgrepos = []
issue_num = 1695948
keywords = []
message_count = 3.0
messages = ['31721', '31722', '31723']
nosy_count = 3.0
nosy_names = ['nnorwitz', 'vinay.sajip', 'jtdeng']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1695948'
versions = ['Python 2.5']

[jtdeng]

Python Version:
===============
Any Python Version

OS Platform:
============
Debian Linux 2.6.8-2-386 #1 Tue Aug 16 12:46:35 UTC 2005 i686 GNU/Linux
Windows XP SP2

Problem:
========
Member function makeSocket() of logging.handlers.SocketHandler creates a socket with no default timeout, and this may block the app on Linux.

def makeSocket(self):
    """
    A factory method which allows subclasses to define the precise
    type of socket they want.
    """
    s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
    s.connect((self.host, self.port))
    return s 

if the log receiver on the destination host is not running, the log sender will block the app on socket.connect(), but on windows, socket.connect() will return immediately. So I propose to provide a default timeout value for makeSocket() like below:

def makeSocket(self, timeout=1):
    """
    A factory method which allows subclasses to define the precise
    type of socket they want.
    """
    s = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
    s.settimeout(timeout)
    s.connect((self.host, self.port))
    return s

[nnorwitz]

Vinay, could you take a look?

[vsajip]

Change (not exactly as above) checked into SVN trunk. New functionality, so not backported.