Patch for Windows build

[theller]

BPO	1751801
Nosy	@gvanrossum, @theller
Files	windows.diff: Patches for windows

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2008-01-06.22:29:45.934>
created_at = <Date 2007-07-11.10:51:03.000>
labels = ['build']
title = 'Patch for Windows build'
updated_at = <Date 2008-01-06.22:29:45.934>
user = 'https://github.com/theller'

bugs.python.org fields:

activity = <Date 2008-01-06.22:29:45.934>
actor = 'admin'
assignee = 'none'
closed = True
closed_date = None
closer = None
components = ['Build']
creation = <Date 2007-07-11.10:51:03.000>
creator = 'theller'
dependencies = []
files = ['8080']
hgrepos = []
issue_num = 1751801
keywords = ['patch']
message_count = 3.0
messages = ['52830', '52831', '52832']
nosy_count = 2.0
nosy_names = ['gvanrossum', 'theller']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue1751801'
versions = ['Python 3.0']

[theller]

In Modules/_fileio.c, HAVE_FTRUNCATE is undefined for Windows.

[gvanrossum]

Looks fine. Can you check this in yourself?

Nit: I note that the line added for _fileio to PC/config.c is improperly indented (space/tab issue?).

Note that this will make various tests using f.truncate() fail. At some point we need to implement it using the same APIs as were used in the old file object.

Also, my hope is that eventually we'll have a Windows specific version of _fileio.c instead of this code, using all-native Windows API calls. (Any volunteers?)

[theller]

Committed as SVN rev. 56264, after fixing the indentation of the added lines in config.c.
Note that config.c is indented partly with tabs, partly with spaces anyway.