Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

struni: Bytes support for TextIOWrapper.write() #45201

Closed
tiran opened this issue Jul 15, 2007 · 2 comments
Closed

struni: Bytes support for TextIOWrapper.write() #45201

tiran opened this issue Jul 15, 2007 · 2 comments
Labels
stdlib Python modules in the Lib dir

Comments

@tiran
Copy link
Member

tiran commented Jul 15, 2007

BPO 1754339
Nosy @gvanrossum, @tiran
Files
  • textiowrapper_bytes.patch: patch against py3k-struni branch r56398
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2008-01-06.22:29:45.867>
    created_at = <Date 2007-07-15.15:54:34.000>
    labels = ['library']
    title = 'struni: Bytes support for TextIOWrapper.write() '
    updated_at = <Date 2008-01-06.22:29:45.867>
    user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2008-01-06.22:29:45.867>
    actor = 'admin'
    assignee = 'none'
    closed = True
    closed_date = None
    closer = None
    components = ['Library (Lib)']
    creation = <Date 2007-07-15.15:54:34.000>
    creator = 'christian.heimes'
    dependencies = []
    files = ['8102']
    hgrepos = []
    issue_num = 1754339
    keywords = ['patch']
    message_count = 2.0
    messages = ['52879', '52880']
    nosy_count = 2.0
    nosy_names = ['gvanrossum', 'christian.heimes']
    pr_nums = []
    priority = 'normal'
    resolution = 'rejected'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue1754339'
    versions = ['Python 3.0']

    @tiran
    Copy link
    Member Author

    tiran commented Jul 15, 2007

    The patch fixes support for bytes in TextIOWrapper.write(). It also fixes some unit test like test_uu, too.

    @tiran tiran closed this as completed Jul 15, 2007
    @tiran tiran added the stdlib Python modules in the Lib dir label Jul 15, 2007
    @tiran tiran closed this as completed Jul 15, 2007
    @tiran tiran added the stdlib Python modules in the Lib dir label Jul 15, 2007
    @gvanrossum
    Copy link
    Member

    This looks like the wrong approach. Instead, I'm changing uu.py to explcitly turn the bytes returned by b2a_uu() into a string. (The alternative would be to require the output file to be opened in binary mode, which makes less sense IMO.) The change is r56402.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants