Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

struni: test_xml_etree.py #45250

Closed
jcgregorio mannequin opened this issue Jul 27, 2007 · 2 comments
Closed

struni: test_xml_etree.py #45250

jcgregorio mannequin opened this issue Jul 27, 2007 · 2 comments
Labels
tests Tests in the Lib/test dir

Comments

@jcgregorio
Copy link
Mannequin

jcgregorio mannequin commented Jul 27, 2007

BPO 1762412
Nosy @loewis
Files
  • test_xml_etree.patch: struni: patches to ElementTree.py
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2008-01-06.22:29:45.782>
    created_at = <Date 2007-07-27.21:03:22.000>
    labels = ['tests']
    title = 'struni: test_xml_etree.py'
    updated_at = <Date 2008-01-06.22:29:45.782>
    user = 'https://bugs.python.org/jcgregorio'

    bugs.python.org fields:

    activity = <Date 2008-01-06.22:29:45.782>
    actor = 'admin'
    assignee = 'none'
    closed = True
    closed_date = None
    closer = None
    components = ['Tests']
    creation = <Date 2007-07-27.21:03:22.000>
    creator = 'jcgregorio'
    dependencies = []
    files = ['8139']
    hgrepos = []
    issue_num = 1762412
    keywords = ['patch']
    message_count = 2.0
    messages = ['52957', '52958']
    nosy_count = 2.0
    nosy_names = ['loewis', 'jcgregorio']
    pr_nums = []
    priority = 'normal'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue1762412'
    versions = ['Python 3.0']

    @jcgregorio
    Copy link
    Mannequin Author

    jcgregorio mannequin commented Jul 27, 2007

    Fixes to ElementTree.py so that the unit tests now pass on the struni branch.

    When writing to a file the output file is now opened in binary mode and the text is converted to bytes before writing.

    In several cases, like _escape_attrib, and _escape_cdata, the encoding was removed and pull out to be as close
    to the write() as possible.

    @jcgregorio jcgregorio mannequin closed this as completed Jul 27, 2007
    @jcgregorio jcgregorio mannequin added the tests Tests in the Lib/test dir label Jul 27, 2007
    @jcgregorio jcgregorio mannequin closed this as completed Jul 27, 2007
    @jcgregorio jcgregorio mannequin added the tests Tests in the Lib/test dir label Jul 27, 2007
    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Jul 28, 2007

    Thanks for the patch. Committed as r56603

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    tests Tests in the Lib/test dir
    Projects
    None yet
    Development

    No branches or pull requests

    0 participants