Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 3137: Remove the buffer API from PyUnicode #45601

Closed
avassalotti opened this issue Oct 11, 2007 · 5 comments
Closed

PEP 3137: Remove the buffer API from PyUnicode #45601

avassalotti opened this issue Oct 11, 2007 · 5 comments
Assignees

Comments

@avassalotti
Copy link
Member

BPO 1260
Nosy @gvanrossum, @avassalotti
Files
  • unicode_rm_buf_api.patch
  • unicode_rm_buf_api_02.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/gvanrossum'
    closed_at = <Date 2007-10-14.02:09:05.825>
    created_at = <Date 2007-10-11.03:00:26.825>
    labels = []
    title = 'PEP 3137: Remove the buffer API from PyUnicode'
    updated_at = <Date 2007-10-14.02:09:05.824>
    user = 'https://github.com/avassalotti'

    bugs.python.org fields:

    activity = <Date 2007-10-14.02:09:05.824>
    actor = 'gvanrossum'
    assignee = 'gvanrossum'
    closed = True
    closed_date = <Date 2007-10-14.02:09:05.825>
    closer = 'gvanrossum'
    components = []
    creation = <Date 2007-10-11.03:00:26.825>
    creator = 'alexandre.vassalotti'
    dependencies = []
    files = ['8507', '8531']
    hgrepos = []
    issue_num = 1260
    keywords = ['patch']
    message_count = 5.0
    messages = ['56336', '56392', '56395', '56400', '56403']
    nosy_count = 2.0
    nosy_names = ['gvanrossum', 'alexandre.vassalotti']
    pr_nums = []
    priority = 'normal'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue1260'
    versions = ['Python 3.0']

    @avassalotti
    Copy link
    Member Author

    This patch removes the buffer API from PyUnicode, as specified by PEP-3137. All the unit tests passes. However, I believe there is a few
    function calls to PyArg API that could become problematic if they are
    given a PyUnicode object:

    % egrep -R --include='*.c' 'PyArg.*Parse.*"[^;:]*[cwt].*"' py3k/

    I haven't checked these function calls yet. So, it would probably be a
    good idea to wait I do so before committing this patch.

    @gvanrossum gvanrossum self-assigned this Oct 11, 2007
    @avassalotti
    Copy link
    Member Author

    There was a problem with one of the call of PyArg_ParseTuple in the OS/2
    version of listdir() in the posix module. I also clarified the error
    message of the 't' format unit.

    @gvanrossum
    Copy link
    Member

    Can you svn update and resolve conflicts? Travis made some changes to
    unicodeobject.c that conflic with your patch.

    @gvanrossum
    Copy link
    Member

    You can check this in. You do have checkin privs right?

    @avassalotti
    Copy link
    Member Author

    Committed in r58455.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants