New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PEP 3137 patch - str8/str comparison should return false #45604
Comments
The main patch - while exactly what is needed to make str8/str equality The second patch modifies structmember.c to use PyUnicode_* where it was Unfortunately, similar errors are present in Python/codecs.c and other |
Oops - use unicode-string-eq-false-r3.patch, not |
Hack to make Python/codecs.c use Unicode strings internally. I recognize The following still fail for me with this patch applied: -- test_compile This is due to PyString_/PyUnicode_/PyBytes_* confusion in the -- test_ctypes -- test_modulefinder -- test_set -- test_sqlite -- test_str This one is a little tricky: str8/str with __str__/unicode ... how -- test_struct -- test_subprocess The following tests fail for me irrespective of whether or not I have r4 -- test_doctest If anybody can give this new patch a try and let me know the result it |
I'll look at this at some point. One quick comment: the lnotab and bytecode On 10/15/07, Thomas Lee <report@bugs.python.org> wrote:
|
I've committed the half of this patch that doesn't break any tests: the Committed revision 58551. I'm seeking help getting the remaining unit tests to pass. (Thanks |
The file I just uploaded is unicode-string-eq-false-all-r4.patch with |
Attached is a patch to fix test_compile. Simple fix of turning an empty |
Attached a fix for test_format. It was testing string interpolation on both str8 and str and using a str The failures I know of left are: |
Attached is a fix for modulefinder. It is an ugly hack as modulefinder took the numeric opcode numbers from Once str8() has its constructor match bytes() then the chr() call can be |
Attached is a fix for sqlite3. First issue was that the dictionary that was being used to store The second issue was that when an object was serialized using |
Attached is a patch to fix test_str. Basically there were a bunch of redundant tests for making sure that |
Guido, what do you want to do about the struct module for the various |
Attached is a fix for test_subprocess. Simply had to change a call to str8() to str(). I am going to run the test suite, but that should leave only test_struct |
Oh, tough call. I think they should return str8 (i.e. bytes after the |
Attached is a fix for test_struct. All of the string tests now assume str8 is returned when arguments of All tests now pass. Re-assigning to myself to check everything in when |
Everything committed in r58596. Thanks for the help, Thomas! |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: