Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch for strftime problem on German Windows #45655

Closed
tiran opened this issue Oct 23, 2007 · 2 comments
Closed

Patch for strftime problem on German Windows #45655

tiran opened this issue Oct 23, 2007 · 2 comments
Assignees
Labels
extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error

Comments

@tiran
Copy link
Member

tiran commented Oct 23, 2007

BPO 1314
Nosy @gvanrossum, @tiran
Files
  • py3k_win_strftime.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/gvanrossum'
    closed_at = <Date 2007-10-23.19:43:34.940>
    created_at = <Date 2007-10-23.08:35:59.734>
    labels = ['extension-modules', 'type-bug']
    title = 'Patch for strftime problem on German Windows'
    updated_at = <Date 2007-10-23.19:43:34.938>
    user = 'https://github.com/tiran'

    bugs.python.org fields:

    activity = <Date 2007-10-23.19:43:34.938>
    actor = 'gvanrossum'
    assignee = 'gvanrossum'
    closed = True
    closed_date = <Date 2007-10-23.19:43:34.940>
    closer = 'gvanrossum'
    components = ['Extension Modules']
    creation = <Date 2007-10-23.08:35:59.734>
    creator = 'christian.heimes'
    dependencies = []
    files = ['8595']
    hgrepos = []
    issue_num = 1314
    keywords = ['patch']
    message_count = 2.0
    messages = ['56675', '56691']
    nosy_count = 2.0
    nosy_names = ['gvanrossum', 'christian.heimes']
    pr_nums = []
    priority = 'normal'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue1314'
    versions = ['Python 3.0']

    @tiran
    Copy link
    Member Author

    tiran commented Oct 23, 2007

    The patch fixes the failing unit tests for time and strptime on German
    and probably other Windows installations.

    •                   ret = PyUnicode_FromStringAndSize(outbuf, buflen);
      

    + ret = PyUnicode_Decode(outbuf, buflen,
    + TZNAME_ENCODING, NULL);

    @tiran tiran added extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error labels Oct 23, 2007
    @gvanrossum
    Copy link
    Member

    Committed revision 58619.

    @gvanrossum gvanrossum self-assigned this Oct 23, 2007
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    extension-modules C modules in the Modules dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants