Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

py3k-pep3137: patch for hashlib on Windows #45728

Closed
amauryfa opened this issue Nov 4, 2007 · 2 comments
Closed

py3k-pep3137: patch for hashlib on Windows #45728

amauryfa opened this issue Nov 4, 2007 · 2 comments

Comments

@amauryfa
Copy link
Member

amauryfa commented Nov 4, 2007

BPO 1387
Nosy @amauryfa, @tiran
Files
  • hashlib.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2007-11-04.23:21:23.292>
    created_at = <Date 2007-11-04.22:12:53.151>
    labels = ['OS-windows']
    title = 'py3k-pep3137: patch for hashlib on Windows'
    updated_at = <Date 2008-01-06.22:29:45.388>
    user = 'https://github.com/amauryfa'

    bugs.python.org fields:

    activity = <Date 2008-01-06.22:29:45.388>
    actor = 'admin'
    assignee = 'none'
    closed = True
    closed_date = <Date 2007-11-04.23:21:23.292>
    closer = 'christian.heimes'
    components = ['Windows']
    creation = <Date 2007-11-04.22:12:53.151>
    creator = 'amaury.forgeotdarc'
    dependencies = []
    files = ['8691']
    hgrepos = []
    issue_num = 1387
    keywords = ['patch']
    message_count = 2.0
    messages = ['57110', '57112']
    nosy_count = 2.0
    nosy_names = ['amaury.forgeotdarc', 'christian.heimes']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue1387'
    versions = ['Python 3.0']

    @amauryfa
    Copy link
    Member Author

    amauryfa commented Nov 4, 2007

    On Windows, openssl is not always available, in this case python uses
    its own implementation of md5, sha1 &co.
    This patch correct the failing tests (test_hashlib and test_uuid), by
    returning bytes instead of buffers.

    @tiran
    Copy link
    Member

    tiran commented Nov 4, 2007

    Thanks!

    Applied in r58847.

    @tiran tiran closed this as completed Nov 4, 2007
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants