Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch to make msvccompiler.py work with vs 2005(MSVC8) #45788

Closed
weck mannequin opened this issue Nov 15, 2007 · 3 comments
Closed

patch to make msvccompiler.py work with vs 2005(MSVC8) #45788

weck mannequin opened this issue Nov 15, 2007 · 3 comments
Labels
build The build process and cross-build topic-installation

Comments

@weck
Copy link
Mannequin

weck mannequin commented Nov 15, 2007

BPO 1447
Nosy @loewis, @tiran
Files
  • msvccompiler.py.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2007-11-15.18:25:25.182>
    created_at = <Date 2007-11-15.14:21:35.141>
    labels = ['build', 'expert-installation']
    title = 'patch to make msvccompiler.py work with vs 2005(MSVC8)'
    updated_at = <Date 2007-11-15.18:25:25.158>
    user = 'https://bugs.python.org/weck'

    bugs.python.org fields:

    activity = <Date 2007-11-15.18:25:25.158>
    actor = 'loewis'
    assignee = 'none'
    closed = True
    closed_date = <Date 2007-11-15.18:25:25.182>
    closer = 'loewis'
    components = ['Installation']
    creation = <Date 2007-11-15.14:21:35.141>
    creator = 'weck'
    dependencies = []
    files = ['8752']
    hgrepos = []
    issue_num = 1447
    keywords = ['patch']
    message_count = 3.0
    messages = ['57530', '57536', '57542']
    nosy_count = 3.0
    nosy_names = ['loewis', 'christian.heimes', 'weck']
    pr_nums = []
    priority = 'normal'
    resolution = 'rejected'
    stage = None
    status = 'closed'
    superseder = None
    type = 'compile error'
    url = 'https://bugs.python.org/issue1447'
    versions = ['Python 2.6', 'Python 3.0']

    @weck
    Copy link
    Mannequin Author

    weck mannequin commented Nov 15, 2007

    It seems that the directory information of MSVC8 *just* can be got from
    environment variable instead of registry.

    This patch make me compile pywin32 with MSVC8(VS 2005).

    @weck weck mannequin added the build The build process and cross-build label Nov 15, 2007
    @tiran
    Copy link
    Member

    tiran commented Nov 15, 2007

    I've checked your patch. It's not enough to move to VS 2005 as the
    default compiler. People expect python setup.py to work w/o opening a VS
    2005 Command Prompt.

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Nov 15, 2007

    tiran is correct. distutils should work without having to invoke a VS
    build environment. Relying on that environment would have worked way
    back to VC6 and earlier, but it would reduce the ease of use of distutils.

    Rejecting the patch.

    @loewis loewis mannequin closed this as completed Nov 15, 2007
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    build The build process and cross-build topic-installation
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant