Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tarfile.TarFile.extractall not setting directory permissions correctly #46076

Closed
eandres mannequin opened this issue Jan 4, 2008 · 3 comments
Closed

tarfile.TarFile.extractall not setting directory permissions correctly #46076

eandres mannequin opened this issue Jan 4, 2008 · 3 comments
Assignees
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@eandres
Copy link
Mannequin

eandres mannequin commented Jan 4, 2008

BPO 1735
Nosy @gustaebel
Files
  • python-tarfile-extractall-fix.patch: Patch for tarfile.py
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/gustaebel'
    closed_at = <Date 2008-01-04.14:47:23.581>
    created_at = <Date 2008-01-04.11:02:40.512>
    labels = ['type-bug', 'library']
    title = 'tarfile.TarFile.extractall not setting directory permissions correctly'
    updated_at = <Date 2008-01-04.14:47:23.580>
    user = 'https://bugs.python.org/eandres'

    bugs.python.org fields:

    activity = <Date 2008-01-04.14:47:23.580>
    actor = 'lars.gustaebel'
    assignee = 'lars.gustaebel'
    closed = True
    closed_date = <Date 2008-01-04.14:47:23.581>
    closer = 'lars.gustaebel'
    components = ['Library (Lib)']
    creation = <Date 2008-01-04.11:02:40.512>
    creator = 'eandres'
    dependencies = []
    files = ['9056']
    hgrepos = []
    issue_num = 1735
    keywords = ['patch']
    message_count = 3.0
    messages = ['59219', '59224', '59227']
    nosy_count = 2.0
    nosy_names = ['lars.gustaebel', 'eandres']
    pr_nums = []
    priority = 'high'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue1735'
    versions = ['Python 2.6', 'Python 2.5', 'Python 3.0']

    @eandres
    Copy link
    Mannequin Author

    eandres mannequin commented Jan 4, 2008

    The tarfile.TarFile.extractall() method is [by default] silently failing
    to set directory permissions and times on all but the lexically-latest
    directory extracted. This is due to an unintentional re-use of the
    'path' variable.

    The provided patch renames the second 'path' variable to 'dirpath' which
    resolves the problem.

    @eandres eandres mannequin added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Jan 4, 2008
    @gustaebel gustaebel mannequin self-assigned this Jan 4, 2008
    @gustaebel
    Copy link
    Mannequin

    gustaebel mannequin commented Jan 4, 2008

    Thanks for the patch. I added a testcase and applied it to the trunk,
    see r59712. Python 2.5 follows later on.

    @gustaebel
    Copy link
    Mannequin

    gustaebel mannequin commented Jan 4, 2008

    Committed to release25-maint branch as r59713.

    @gustaebel gustaebel mannequin closed this as completed Jan 4, 2008
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    0 participants