nonexistent data items declared as exports in sysmodule.h

[jlaurila]

BPO	1783
Nosy	@tiran, @serhiy-storchaka
Files	sysmodule_h_cleanup-2.7.patch sysmodule_h_cleanup-3.x.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/serhiy-storchaka'
closed_at = <Date 2013-02-01.11:24:47.571>
created_at = <Date 2008-01-10.15:54:11.807>
labels = ['interpreter-core', 'easy', 'type-bug']
title = 'nonexistent data items declared as exports in sysmodule.h'
updated_at = <Date 2013-02-01.11:24:47.569>
user = 'https://bugs.python.org/jlaurila'

bugs.python.org fields:

activity = <Date 2013-02-01.11:24:47.569>
actor = 'serhiy.storchaka'
assignee = 'serhiy.storchaka'
closed = True
closed_date = <Date 2013-02-01.11:24:47.571>
closer = 'serhiy.storchaka'
components = ['Interpreter Core']
creation = <Date 2008-01-10.15:54:11.807>
creator = 'jlaurila'
dependencies = []
files = ['28910', '28911']
hgrepos = []
issue_num = 1783
keywords = ['patch', 'easy']
message_count = 6.0
messages = ['59663', '59667', '116862', '180983', '181075', '181076']
nosy_count = 5.0
nosy_names = ['christian.heimes', 'jlaurila', 'BreamoreBoy', 'python-dev', 'serhiy.storchaka']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue1783'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3', 'Python 3.4']

[jlaurila]

sysmodule.h contains the following declarations for data to be exported
from the Python DLL, but these variables don't seem to exist anywhere:

PyAPI_DATA(PyObject *) _PySys_TraceFunc, *_PySys_ProfileFunc;
PyAPI_DATA(int) _PySys_CheckInterval;

Either the declarations should be removed or the variables should be
defined somewhere. I'm proposing the former.

[tiran]

Sounds good to me. The vars were probably forgotten. The header files
may contain more missing vars, too.

[BreamoreBoy]

The 1st declaration still exists, the 2nd has been removed.

[serhiy-storchaka]

Here are patches.

[python-dev]

New changeset 6074530b526f by Serhiy Storchaka in branch '2.7':
Issue bpo-1783: Remove declarations of nonexistent private variables.
http://hg.python.org/cpython/rev/6074530b526f

New changeset 349419bb6283 by Serhiy Storchaka in branch '3.2':
Issue bpo-1783: Remove declarations of nonexistent private variables.
http://hg.python.org/cpython/rev/349419bb6283

New changeset 9d68f705e25f by Serhiy Storchaka in branch '3.3':
Issue bpo-1783: Remove declarations of nonexistent private variables.
http://hg.python.org/cpython/rev/9d68f705e25f

New changeset 905b4e3cf6d0 by Serhiy Storchaka in branch 'default':
Issue bpo-1783: Remove declarations of nonexistent private variables.
http://hg.python.org/cpython/rev/905b4e3cf6d0

[serhiy-storchaka]

Thank you for the report, Jukka Laurila.