test_wave.py converted to unittest

[giampaolo]

BPO	1951
Nosy	@facundobatista, @giampaolo, @tiran
Files	test_wave.diff: test_wave.py converted to unittest

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2008-02-05.19:06:55.649>
created_at = <Date 2008-01-28.00:03:39.112>
labels = ['easy', 'type-feature', 'tests']
title = 'test_wave.py converted to unittest'
updated_at = <Date 2008-02-06.18:49:33.093>
user = 'https://github.com/giampaolo'

bugs.python.org fields:

activity = <Date 2008-02-06.18:49:33.093>
actor = 'giampaolo.rodola'
assignee = 'none'
closed = True
closed_date = <Date 2008-02-05.19:06:55.649>
closer = 'facundobatista'
components = ['Tests']
creation = <Date 2008-01-28.00:03:39.112>
creator = 'giampaolo.rodola'
dependencies = []
files = ['9304']
hgrepos = []
issue_num = 1951
keywords = ['patch', 'easy']
message_count = 6.0
messages = ['61754', '61755', '61795', '61796', '62077', '62114']
nosy_count = 3.0
nosy_names = ['facundobatista', 'giampaolo.rodola', 'christian.heimes']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue1951'
versions = ['Python 2.6']

[giampaolo]

In attachment.

[giampaolo]

Sorry but I realized right now by reading Lib/test/readme.txt that the
test scripts are required to have a global "test_main()" function
defined hence the "main()" function I defined in my patch should be
renamed in "test_main()".

[tiran]

Thanks for the patch!

[giampaolo]

Glad to help.

[facundobatista]

Applied in r60602. Thank you very much!

Note that I had to apply the patch by hand... I think that the problem
was in the header: if I get a svn diff, it starts differently than you
patch:

facundo@virtub:~/devel/reps/python/trunk$ svn diff -r 60601
Lib/test/test_wave.py
Index: Lib/test/test_wave.py
===================================================================
--- Lib/test/test_wave.py (revisión: 60601)
+++ Lib/test/test_wave.py (copia de trabajo)
@@ -1,32 +1,45 @@
...

I noted that you submitted other patch in other issue, please check that
one to be ok.

Thanks again!!

[giampaolo]

You're right. It seems that TortoiseSVN generated diff files are
different than using the original svn cmd line tool (probably I'm using
TortoiseSVN in the wrong way).
I'll update the other patches.