Distutils' mkpath implementation ignoring the "mode" parameter

[henrique]

BPO	2236
Nosy	@orsenthil, @pitrou, @tarekziade, @merwok, @akitada, @bitdancer
Files	python2.5-distutils_mkpath_filemode.v1.diff: Patch python-distutils_mkpath_filemode-v2.diff python-distutils_mkpath_filemode-test-update.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/orsenthil'
closed_at = <Date 2010-09-19.04:21:41.093>
created_at = <Date 2008-03-04.20:56:47.897>
labels = ['easy', 'type-bug', 'library']
title = 'Distutils\' mkpath implementation ignoring the "mode" parameter'
updated_at = <Date 2010-09-19.04:21:41.091>
user = 'https://bugs.python.org/henrique'

bugs.python.org fields:

activity = <Date 2010-09-19.04:21:41.091>
actor = 'orsenthil'
assignee = 'orsenthil'
closed = True
closed_date = <Date 2010-09-19.04:21:41.093>
closer = 'orsenthil'
components = ['Distutils']
creation = <Date 2008-03-04.20:56:47.897>
creator = 'henrique'
dependencies = []
files = ['9605', '18887', '18927']
hgrepos = []
issue_num = 2236
keywords = ['patch', 'easy']
message_count = 14.0
messages = ['63259', '64177', '81180', '107641', '108887', '115052', '116430', '116433', '116678', '116702', '116750', '116840', '116848', '116849']
nosy_count = 10.0
nosy_names = ['gward', 'jafo', 'orsenthil', 'pitrou', 'tarek', 'henrique', 'eric.araujo', 'akitada', 'r.david.murray', 'chromano']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue2236'
versions = ['Python 3.1', 'Python 2.7', 'Python 3.2']

[henrique]

The default value for mkpath's mode parameter is 0777 but it isn't used
at any place; attached is a patch that just pass the parameter to
os.mkdir call, this seems to fix the problem.

[jafo]

This patch looks good to me. Greg?

[akitada]

Still present in 2.6/3.0

[merwok]

Confirmed in trunk (2.7rc2), py3k (3.2), irrelevant for distutils2. Is it too late for 2.7?

[gward]

Is it too late for 2.7?

I have no idea.

It does look as though someone has written unit tests for distutils, so the patch needs a test change too. Henrique?

[gward]

I'm unassigning this since I no longer know how to commit changes to Python. Sorry, I just haven't kept track over the years, I don't follow python-dev anymore, and I could not find documentation explaining where I should commit what sort of changes.

[chromano]

Patch updated, now it includes test.

[chromano]

Improving tests

[orsenthil]

Fixed for py3k in r84861, release31-maint in r84863 and release27-maint in r84862.

Thanks for patch, Carlos Henrique Romano.

[bitdancer]

This update appears to be turning the windows buildbots red. See for example http://www.python.org/dev/buildbot/all/builders/x86 XP-4 3.1/builds/1230/steps/test/logs/stdio.

[orsenthil]

I have skipped the mode tests on windows platforms, as they are not
really applicable.
Lets see the buildbots status and close the bug.

[pitrou]

All buildbots are red.

[chromano]

Updating test in order to consider umask, this is supposed to fix buildbot issues.

[orsenthil]

Buildbots are green now after fixing the mode issue in the tests in r84889,r84890,r84891