Compiler warnings when using UCS4

[benjaminp]

BPO	2388
Nosy	@loewis, @tiran, @benjaminp

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/tiran'
closed_at = <Date 2008-04-07.03:08:52.386>
created_at = <Date 2008-03-18.14:00:11.636>
labels = ['easy', 'build', 'expert-unicode']
title = 'Compiler warnings when using UCS4'
updated_at = <Date 2008-04-07.03:08:52.385>
user = 'https://github.com/benjaminp'

bugs.python.org fields:

activity = <Date 2008-04-07.03:08:52.385>
actor = 'loewis'
assignee = 'christian.heimes'
closed = True
closed_date = <Date 2008-04-07.03:08:52.386>
closer = 'loewis'
components = ['Unicode']
creation = <Date 2008-03-18.14:00:11.636>
creator = 'benjamin.peterson'
dependencies = []
files = []
hgrepos = []
issue_num = 2388
keywords = ['easy']
message_count = 7.0
messages = ['63913', '63914', '63916', '63918', '64254', '64655', '65060']
nosy_count = 3.0
nosy_names = ['loewis', 'christian.heimes', 'benjamin.peterson']
pr_nums = []
priority = 'high'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue2388'
versions = ['Python 2.6']

[benjaminp]

Compiling Python with --enable-unicode=ucs4 yields some compiler
warnings for unicodeobject.c:
In file included from Objects/unicodeobject.c:7807:
Objects/stringlib/string_format.h: In function 'do_conversion':
Objects/stringlib/string_format.h:745: warning: format '%c' expects type
'int', but argument 3 has type 'Py_UNICODE'
In file included from Objects/unicodeobject.c:7807:
Objects/stringlib/string_format.h: In function 'do_conversion':
Objects/stringlib/string_format.h:745: warning: format '%c' expects type
'int', but argument 3 has type 'Py_UNICODE'
Objects/unicodeobject.c: In function 'PyUnicodeUCS4_Format':
Objects/unicodeobject.c:8603: warning: format '%c' expects type 'int',
but argument 3 has type 'Py_UNICODE'
Objects/unicodeobject.c: In function 'PyUnicodeUCS4_Format':
Objects/unicodeobject.c:8603: warning: format '%c' expects type 'int',
but argument 3 has type 'Py_UNICODE'

[loewis]

What operating system/compiler? Both branches? What precise revisions?

[benjaminp]

This is MacOS 10.4, Apple gcc 4.0.1, and revision 61518.

[benjaminp]

There are similar warnings in formater_unicode.c:
In file included from Python/formatter_unicode.c:13:
Python/../Objects/stringlib/formatter.h: In function 'unicode__format__':
Python/../Objects/stringlib/formatter.h:789: warning: format '%c'
expects type 'int', but argument 3 has type 'Py_UNICODE'
In file included from Python/formatter_unicode.c:13:
Python/../Objects/stringlib/formatter.h: In function 'unicode__format__':
Python/../Objects/stringlib/formatter.h:789: warning: format '%c'
expects type 'int', but argument 3 has type 'Py_UNICODE'

[tiran]

I'll check it out later. I haven't been testing UCS4 builds for more
than a month.

[benjaminp]

This is because in UCS, Py_UNICODE is an unsigned long. In calls to
PyErr_Format, the format specifier %c (int, the UCS2 Py_UNICODE) is
given, so the compiler gives a warning.

[loewis]

This is now fixed in r62199