urllib2.Request constructor has no timeout parameter

[jjlee]

BPO	2450
Nosy	@facundobatista

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/facundobatista'
closed_at = <Date 2008-03-22.00:50:47.745>
created_at = <Date 2008-03-21.22:58:08.281>
labels = ['library']
title = 'urllib2.Request constructor has no timeout parameter'
updated_at = <Date 2008-03-22.02:28:24.516>
user = 'https://bugs.python.org/jjlee'

bugs.python.org fields:

activity = <Date 2008-03-22.02:28:24.516>
actor = 'jjlee'
assignee = 'facundobatista'
closed = True
closed_date = <Date 2008-03-22.00:50:47.745>
closer = 'facundobatista'
components = ['Library (Lib)']
creation = <Date 2008-03-21.22:58:08.281>
creator = 'jjlee'
dependencies = []
files = []
hgrepos = []
issue_num = 2450
keywords = []
message_count = 5.0
messages = ['64291', '64304', '64307', '64308', '64311']
nosy_count = 2.0
nosy_names = ['facundobatista', 'jjlee']
pr_nums = []
priority = 'normal'
resolution = 'wont fix'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue2450'
versions = ['Python 2.6']

[jjlee]

r55792 added timeout support to urllib2. A timeout parameter was added
to urllib2.OpenerDirector.open(), but there is no corresponding Request
constructor parameter. timeout is unique in that respect. Instead,
OpenerDirector.open() sets req.timeout on request instances. The
parameter "timeout" should behave in the same way as existing parameter
"data".

[facundobatista]

The argument timeout can not have the same semantics than data, see the
following cases:

• r = Request(url)

• urlopen(r, data="foo")

• data is "foo"

• r = Request(url, data="foo")

• urlopen(r)

• data is "foo"

• r = Request(url, data="foo")

• urlopen(r, data="bar")

• data is "bar"

So, what would happen if you put timeout in Request:

• r = Request(url, timeout=3)

• urlopen(r, timeout=10)

• here, the final timeout can be 10, no problem!

• r = Request(url, timeout=3)

• urlopen(r)

• Oops!

In this last one, which the final timeout should be? None, as you passed
that to urlopen()? Or the original 3 from the Request?

With data you can do it, because None has no meaning, so only you
replace the Request value if actually you passed something in urlopen().
But for timeout, None *has* a meaning...

[jjlee]

This should be solved by introducing a "not set" value other than None.

[facundobatista]

As I wrote in the other bug that you opened (bpo-2451), introducing this
will complicate the usage and semantics of what is already established
and working.

[jjlee]

I don't buy the "API complication" argument.

I might accept an argument that the timeout isn't really anything to do
with the request, so I won't bother to continue with this bug report.