memoryview of bytes is not readonly

[amauryfa]

BPO	2538
Nosy	@theller, @gpshead, @amauryfa, @pitrou, @benjaminp
Files	buffer.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2008-08-02.21:03:18.843>
created_at = <Date 2008-04-03.00:26:21.768>
labels = ['interpreter-core', 'type-bug', 'release-blocker']
title = 'memoryview of bytes is not readonly'
updated_at = <Date 2008-08-02.21:03:18.842>
user = 'https://github.com/amauryfa'

bugs.python.org fields:

activity = <Date 2008-08-02.21:03:18.842>
actor = 'pitrou'
assignee = 'teoliphant'
closed = True
closed_date = <Date 2008-08-02.21:03:18.843>
closer = 'pitrou'
components = ['Interpreter Core']
creation = <Date 2008-04-03.00:26:21.768>
creator = 'amaury.forgeotdarc'
dependencies = []
files = ['9929']
hgrepos = []
issue_num = 2538
keywords = ['patch']
message_count = 6.0
messages = ['64886', '64964', '65068', '70357', '70390', '70644']
nosy_count = 7.0
nosy_names = ['nnorwitz', 'theller', 'gregory.p.smith', 'teoliphant', 'amaury.forgeotdarc', 'pitrou', 'benjamin.peterson']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue2538'
versions = ['Python 3.0']

[amauryfa]

Bytes should be immutable, but in test_socket.py:
buf = b" "*1024
nbytes = self.cli_conn.recv_into(buf)

This patch attempts to enforce readonly buffer on bytes

[nnorwitz]

Travis, could you take a look?

[gpshead]

This patch looks good.

One question: in Objects/abstract.c in PyBuffer_FillInfo, why is it even
testing for the PyBUF_LOCK flag at all? PEP-3118 says its valid for
both reading and writing (if the underlying object supports locked access).

BTW, I is someone is going to merge any py3k buffer api related changes
back into the backport that is in 2.6?

[benjaminp]

How's this coming?

[pitrou]

The patch should probably come with a test :)

[pitrou]

Fixed in r65420, with a test.