Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The position of special value tables (cmathmodule.c) #46916

Closed
ocean-city mannequin opened this issue Apr 21, 2008 · 4 comments
Closed

The position of special value tables (cmathmodule.c) #46916

ocean-city mannequin opened this issue Apr 21, 2008 · 4 comments
Assignees
Labels
extension-modules C modules in the Modules dir

Comments

@ocean-city
Copy link
Mannequin

ocean-city mannequin commented Apr 21, 2008

BPO 2664
Nosy @mdickinson
Files
  • cmathmodule.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/mdickinson'
    closed_at = <Date 2008-05-16.15:08:03.623>
    created_at = <Date 2008-04-21.00:42:40.936>
    labels = ['extension-modules']
    title = 'The position of special value tables (cmathmodule.c)'
    updated_at = <Date 2008-05-16.15:08:03.583>
    user = 'https://bugs.python.org/ocean-city'

    bugs.python.org fields:

    activity = <Date 2008-05-16.15:08:03.583>
    actor = 'mark.dickinson'
    assignee = 'mark.dickinson'
    closed = True
    closed_date = <Date 2008-05-16.15:08:03.623>
    closer = 'mark.dickinson'
    components = ['Extension Modules']
    creation = <Date 2008-04-21.00:42:40.936>
    creator = 'ocean-city'
    dependencies = []
    files = ['10070']
    hgrepos = []
    issue_num = 2664
    keywords = ['patch']
    message_count = 4.0
    messages = ['65657', '66483', '66502', '66948']
    nosy_count = 2.0
    nosy_names = ['mark.dickinson', 'ocean-city']
    pr_nums = []
    priority = 'normal'
    resolution = 'wont fix'
    stage = None
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue2664'
    versions = ['Python 2.6']

    @ocean-city
    Copy link
    Mannequin Author

    ocean-city mannequin commented Apr 21, 2008

    If putting special value tables near function is preferable,
    (as before) probably this patch helps.

    @ocean-city ocean-city mannequin added the extension-modules C modules in the Modules dir label Apr 21, 2008
    @ocean-city ocean-city mannequin assigned mdickinson Apr 21, 2008
    @mdickinson
    Copy link
    Member

    I'm actually pretty happy with the tables the way they are; everything's
    working at the moment, and the current code seems clear enough.

    Do you have a strong reason to want this change?

    @ocean-city
    Copy link
    Mannequin Author

    ocean-city mannequin commented May 9, 2008

    Nope, I don't have strong reason. I just thought exceeding 80 line width
    is a little ugly, and if data and function are close you can refer both
    more easily. Please feel free to close this entry as "WONT FIX".

    @mdickinson
    Copy link
    Member

    I agree that having lines >= 80 characters long is ugly (and violates PEP-7). But I think this particular case falls under the 'rules are made to
    be broken' comment at the start of PEP-7.

    I like the fact that if you squint at the tables hard enough, each one
    looks almost like a copy of the complex plane. :-).

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    extension-modules C modules in the Modules dir
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant