New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2to3 Fix_imports optimization #47468
Comments
This is an optimization in pytree.py specifically for the bare_name |
Here are the changes we talked about to fix_imports.py which remove the |
The change to pytree.py doesn't add much speed benefit over the The fix_imports.py change, on the other hand, takes the test suite run That said, I don't think the change is correct: you remove the portion |
Here is a diff for the both the fix_imports changes which I corrected, |
fix_imports.diff fails to apply cleanly against HEAD of fix_imports.py. + yield """power< module_name=%r Why are you using import_as_names here? That's meant to match a series |
Yeah that import_as_names definitely shouldn't be there. I don't know |
I've fixed the tests, so you can cross that one off your list. However, |
I can hopefully have it all fixed up by tonight or tomorrow. |
Can we expect this in the next 2 hours? It's fine if not, I just need to |
It should be done tonight, but probably not until around 11 central |
Sorry I couldn't have this done earlier today. I updated the test suite, |
Thanks very much for getting this done! I checked in the changes in |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: