Windows SQLite DLL should be built with multithreading enabled

[ghaering]

BPO	3853
Nosy	@loewis, @amauryfa

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/loewis'
closed_at = <Date 2008-09-18.18:21:34.131>
created_at = <Date 2008-09-12.22:45:52.454>
labels = ['easy', 'type-feature', 'OS-windows', 'build']
title = 'Windows SQLite DLL should be built with multithreading enabled'
updated_at = <Date 2008-09-18.18:21:34.130>
user = 'https://bugs.python.org/ghaering'

bugs.python.org fields:

activity = <Date 2008-09-18.18:21:34.130>
actor = 'loewis'
assignee = 'loewis'
closed = True
closed_date = <Date 2008-09-18.18:21:34.131>
closer = 'loewis'
components = ['Build', 'Windows']
creation = <Date 2008-09-12.22:45:52.454>
creator = 'ghaering'
dependencies = []
files = []
hgrepos = []
issue_num = 3853
keywords = ['easy']
message_count = 3.0
messages = ['73148', '73179', '73394']
nosy_count = 3.0
nosy_names = ['loewis', 'ghaering', 'amaury.forgeotdarc']
pr_nums = []
priority = 'high'
resolution = 'works for me'
stage = None
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue3853'
versions = ['Python 2.6', 'Python 3.0']

[ghaering]

According to http://www.sqlite.org/faq.html#q6 SQLite should be built
with SQLITE_THREADSAFE defined when the library is used in a
multithreaded context.

This doesn't mean that the connection objects can then be shared between
threads. This they cannot. But that if the SQLite API is used from more
than one thread, then the library must be built with the
SQLITE_THREADSAFE option.

[amauryfa]

It seems that it is already the case. On Windows, a one-big-source-file
version of sqlite is used, fetched from
http://svn.python.org/projects/external/sqlite-3.5.9
(see Tools/buildbot/external-common.bat)

and in this file, SQLITE_THREADSAFE is always set to 1, unless you
explicitely compile with "THREADSAFE=0".

[loewis]

I agree with Amaury's analysis (except that the preferred way to
override it is to define SQLITE_THREADSAFE directly). If it's not
defined, it defaults to 1.

Closing as works-for-me.