New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch to implement a real ftplib test suite #48189
Comments
ftplib module is currently lacking a test suite which actually connects Tested against Python 2.6-RC2 on Windows XP SP3, Linux 2.6.20 and |
Awesome! I'll look at this soon. |
Giampaolo, my review comments are on Rietveld: |
Patch modified after the remarks discussed with Benjamin is in attachment. |
Excellent! Barry gave me permission to put this in 2.6, so I'll do so soon. |
Commited in r66634. |
Giampaolo, I'm seeing some failures on the buildbots like this: Do you know where they are arising from? |
I think the patch in attachment could solve the problem. |
Thanks. That seems to have done the trick. |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
bugs.python.org fields:
The text was updated successfully, but these errors were encountered: