Disable Py_USING_MEMORY_DEBUGGER!

[vstinner]

BPO	3951
Nosy	@loewis, @vstinner, @benjaminp
Files	configure-memory-debugger.patch: Create --with-memory-debugger option obmalloc-no-debug.patch: Remove definition of Py_USING_MEMORY_DEBUGGER from obmalloc.c (done by configure using my first patch) revert.diff

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2008-09-30.18:20:27.452>
created_at = <Date 2008-09-24.00:29:17.953>
labels = []
title = 'Disable Py_USING_MEMORY_DEBUGGER!'
updated_at = <Date 2008-09-30.18:20:27.450>
user = 'https://github.com/vstinner'

bugs.python.org fields:

activity = <Date 2008-09-30.18:20:27.450>
actor = 'vstinner'
assignee = 'none'
closed = True
closed_date = <Date 2008-09-30.18:20:27.452>
closer = 'vstinner'
components = []
creation = <Date 2008-09-24.00:29:17.953>
creator = 'vstinner'
dependencies = []
files = ['11583', '11584', '11596']
hgrepos = []
issue_num = 3951
keywords = ['patch']
message_count = 7.0
messages = ['73683', '73691', '73697', '73743', '73756', '73769', '74091']
nosy_count = 3.0
nosy_names = ['loewis', 'vstinner', 'benjamin.peterson']
pr_nums = []
priority = 'normal'
resolution = None
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue3951'
versions = ['Python 2.6', 'Python 3.0']

[vstinner]

In rev 56476, martin.v.loewis enabled Py_USING_MEMORY_DEBUGGER by
default in an huge commit:
PEP-3123: Provide forward compatibility with Python 3.0,
while keeping backwards compatibility. Add Py_Refcnt,
Py_Type, Py_Size, and PyVarObject_HEAD_INIT.

I guess that's an error, and that Py_USING_MEMORY_DEBUGGER should be
disabled by default.

Proposition to avoid such bug in future: create a configure option,
like --with-memory-debugger. See for example my patch to configure.in
(you will need to run autoconf && autoheader).

[loewis]

You are right that this was by mistake; here is a patch to revert that
mistake (revert.diff).

I'm marking the issue release-critical because of thsi patch; the other
patches (for adding a new configure option) clearly can't go into 2.6,
and might need to be deferred to 2.7.

[vstinner]

@loewis: your patch (revert.diff) includes a change in configure.in
about OpenBSD !?

[loewis]

Sorry about that - let me retry.

[benjaminp]

Looks good to me.

[loewis]

Committed as r66616 and r66617

[vstinner]

Close the issue since it's commited in 2.6 and 3.0. My patch
configure-memory-debugger.patch is useless, a developer can fix
obmalloc.c.