Remove checks for win NT

[eckhardt]

BPO	4856
Nosy	@loewis, @amauryfa
Files	python-2.7-win9x-wchar-checks.0.patch: patch remove_w9x_code.patch remove_unused_function.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2009-06-29.11:39:23.601>
created_at = <Date 2009-01-06.08:55:47.153>
labels = ['interpreter-core', 'type-feature']
title = 'Remove checks for win NT'
updated_at = <Date 2009-06-29.11:39:23.600>
user = 'https://bugs.python.org/eckhardt'

bugs.python.org fields:

activity = <Date 2009-06-29.11:39:23.600>
actor = 'ocean-city'
assignee = 'ocean-city'
closed = True
closed_date = <Date 2009-06-29.11:39:23.601>
closer = 'ocean-city'
components = ['Interpreter Core']
creation = <Date 2009-01-06.08:55:47.153>
creator = 'eckhardt'
dependencies = []
files = ['12618', '14327', '14381']
hgrepos = []
issue_num = 4856
keywords = ['patch']
message_count = 14.0
messages = ['79237', '79249', '79252', '79306', '87960', '89559', '89570', '89765', '89766', '89774', '89820', '89823', '89825', '89826']
nosy_count = 4.0
nosy_names = ['loewis', 'amaury.forgeotdarc', 'ocean-city', 'eckhardt']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue4856'
versions = ['Python 2.7', 'Python 3.2']

[eckhardt]

There are several checks like "GetVersion() < 0x80000000" that try to
determine whether there is support for the WCHAR versions of the win32
API. Since all support for MS Windows 95, 98 and ME has been dropped,
all supported systems support those APIs. Also, I need that cleanup as
preparation for porting Python to MS Windows CE, so that I don't have
to clone/port code for obsolete systems there. I'll be providing
patches here.

[amauryfa]

+1

[eckhardt]

This patch removes all calls to win32's GetVersion() where they are used
to detect NT. In posixmodule.c it was used by a wrapper function that
cached the result, which then also became obsolete.

[ocean-city]

+1. I've tested this patch on win2k & vc6, and worked correctly.

[loewis]

The patch is slightly out of date; if updated, it is fine to apply after
3.1.

I think Py_GetFileAttributesExA can also be removed.

[ocean-city]

Here is an updated patch with Py_GetFileAttributesEx[AW] removal.
I propose to commit this to trunk, and merge it to py3k after 3.1 will
be released.

[loewis]

I think it's easier if the patch just sits here for six more days; 3.1
won't take much longer.

[ocean-city]

OK, 3.1 was out. Can I commit this to trunk and merge it to py3k?

[loewis]

Sure, go ahead.

[ocean-city]

Thanks, committed in r73603(trunk) and r73604(py3k).

[amauryfa]

The functions Py_GetFileAttributesExA and Py_GetFileAttributesExW were
not removed. Is it intended?

[ocean-city]

Oops, sorry. This function is not needed if GetFileAttributesEx never
fail with ERROR_CALL_NOT_IMPLEMENTED. I believe this won't happen on win
NT. How about this patch?

[amauryfa]

Yes, that's what I had in mind.

[ocean-city]

Thanks, committed in r73675(trunk) and r73676(py3k).