setup.py crashes if sqlite version contains 'beta'

[blahblahwhat]

BPO	5033
Nosy	@tarekziade, @merwok, @akheron, @pelme
Files	issue5033.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2013-02-23.16:29:20.820>
created_at = <Date 2009-01-22.16:23:25.272>
labels = ['easy', 'build']
title = "setup.py crashes if sqlite version contains 'beta'"
updated_at = <Date 2013-02-23.16:29:20.818>
user = 'https://bugs.python.org/blahblahwhat'

bugs.python.org fields:

activity = <Date 2013-02-23.16:29:20.818>
actor = 'petri.lehtinen'
assignee = 'none'
closed = True
closed_date = <Date 2013-02-23.16:29:20.820>
closer = 'petri.lehtinen'
components = ['Build']
creation = <Date 2009-01-22.16:23:25.272>
creator = 'blahblahwhat'
dependencies = []
files = ['29171']
hgrepos = []
issue_num = 5033
keywords = ['patch', 'easy']
message_count = 6.0
messages = ['80370', '116570', '121413', '182748', '182756', '182757']
nosy_count = 8.0
nosy_names = ['ghaering', 'tarek', 'eric.araujo', 'blahblahwhat', 'BreamoreBoy', 'python-dev', 'petri.lehtinen', 'Andreas.Pelme']
pr_nums = []
priority = 'low'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'compile error'
url = 'https://bugs.python.org/issue5033'
versions = ['Python 2.7', 'Python 3.2', 'Python 3.3', 'Python 3.4']

[blahblahwhat]

When I try to 'make' Python 2.6.1:

Traceback (most recent call last):
  File "./setup.py", line 1880, in <module>
    main()
  File "./setup.py", line 1875, in main
    'Lib/smtpd.py']
  File "/home/apps/Python-2.6.1/Lib/distutils/core.py", line 152, in 
setup
    dist.run_commands()
  File "/home/apps/Python-2.6.1/Lib/distutils/dist.py", line 975, in 
run_commands
    self.run_command(cmd)
  File "/home/apps/Python-2.6.1/Lib/distutils/dist.py", line 995, in 
run_command
    cmd_obj.run()
  File "/home/apps/Python-2.6.1/Lib/distutils/command/build.py", line 
134, in run
    self.run_command(cmd_name)
  File "/home/apps/Python-2.6.1/Lib/distutils/cmd.py", line 333, in 
run_command
    self.distribution.run_command(command)
  File "/home/apps/Python-2.6.1/Lib/distutils/dist.py", line 995, in 
run_command
    cmd_obj.run()
  File "/home/apps/Python-2.6.1/Lib/distutils/command/build_ext.py", 
line 343, in run
    self.build_extensions()
  File "./setup.py", line 103, in build_extensions
    missing = self.detect_modules()
  File "./setup.py", line 915, in detect_modules
    for x in sqlite_version.split(".")])
ValueError: invalid literal for int() with base 10: '1beta'

This was solved by replacing

  m = re.search(r'\s*.*#\s*.*define\s.*SQLITE_VERSION\W*"(.*)"', incf)

with

  m = re.search(r'\s*.*#\s*.*define\s.*SQLITE_VERSION\W*"([\d\.]*)"', 
incf)

on line 911

[BreamoreBoy]

A one line fix is given in msg80370, can this be applied,should the issue be closed or what?

[merwok]

The regex is still the same. I’ll try changing the version string in sqlite and trigger the bug.

[pelme]

This bug still exists in 2.7 and 3.4.

If SQLITE_VERSION in sqlite3.h (/usr/include/sqlite3.h on Mac OS) ends with beta, such as
 
#define SQLITE_VERSION        "3.7.12beta"

make will fail.

The regex changed suggested above fixes this. The attached patch contains that fix and makes the build work.

[python-dev]

New changeset 8b177aea9ddd by Petri Lehtinen in branch '2.7':
Issue bpo-5033: Fix building of the sqlite3 extension module
http://hg.python.org/cpython/rev/8b177aea9ddd

New changeset 73d5dd480558 by Petri Lehtinen in branch '3.2':
Issue bpo-5033: Fix building of the sqlite3 extension module
http://hg.python.org/cpython/rev/73d5dd480558

New changeset c613eb716c8e by Petri Lehtinen in branch '3.3':
Issue bpo-5033: Fix building of the sqlite3 extension module
http://hg.python.org/cpython/rev/c613eb716c8e

New changeset 19b3aaf79e45 by Petri Lehtinen in branch 'default':
Issue bpo-5033: Fix building of the sqlite3 extension module
http://hg.python.org/cpython/rev/19b3aaf79e45

[akheron]

Applied, thanks!