httplib: wrong Host header when connecting to IPv6 litteral URL

[gdesmott]

BPO	5111
Nosy	@orsenthil, @pitrou, @vstinner, @merwok
Files	5111.diff: patch file 5311_test.diff: test_httplib patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/orsenthil'
closed_at = <Date 2010-11-14.03:33:09.920>
created_at = <Date 2009-01-30.16:48:57.723>
labels = ['type-bug', 'library']
title = 'httplib: wrong Host header when connecting to IPv6 litteral URL'
updated_at = <Date 2010-11-14.03:33:09.919>
user = 'https://bugs.python.org/gdesmott'

bugs.python.org fields:

activity = <Date 2010-11-14.03:33:09.919>
actor = 'orsenthil'
assignee = 'orsenthil'
closed = True
closed_date = <Date 2010-11-14.03:33:09.920>
closer = 'orsenthil'
components = ['Library (Lib)']
creation = <Date 2009-01-30.16:48:57.723>
creator = 'gdesmott'
dependencies = []
files = ['14425', '14430']
hgrepos = []
issue_num = 5111
keywords = ['patch']
message_count = 8.0
messages = ['80827', '80829', '90005', '90006', '90016', '90028', '121132', '121173']
nosy_count = 7.0
nosy_names = ['orsenthil', 'pitrou', 'vstinner', 'dmorr', 'eric.araujo', 'gdesmott', 'chkneo']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue5111'
versions = ['Python 3.1', 'Python 2.7', 'Python 3.2']

[gdesmott]

To reproduce:

• Launch a HTTP server listening on an Inet6 socket on, say, port 5555
• Try to connect using the IPv6 loopback:
  http = httplib.HTTPConnection('[::1]:5555')
  http.request('GET', '/foo')
  r = http.getresponse()
  print r.status
• You get 400 (bad-request) instead of 404

It seems that's because the HTTP request is wrong. Python sends this header:
Host: ::1:5555
but it should be:
Host: [::1]:5555

I'm using python 2.5.2-1ubuntu1 on Intrepid.

[gdesmott]

Actually, this bug is present when you try to connect to any URL
containing an IP6 and a port.

So, we have the same problem when using, for example:
http = httplib.HTTPConnection('[2a01:8790:16d:0:218:de87:164:8745]:5555')

but
http = httplib.HTTPConnection('[2001:4860:0:1001::68]:80')

does work. Probably because we use the default HTTP port.

[chkneo]

As per the RFC 2732 host header should be wrapped with []. I am
attaching patch for this too which is applied on trunk(2.7)

[chkneo]

RFC 2732 Section three have the following details.

      host          = hostname | IPv4address | IPv6reference
      ipv6reference = "[" IPv6address "]"

The patch contains check for : and adding the brackets

[pitrou]

Thanks for the patch. It would be better if you also added a test to
Lib/test/test_httplib.py (unless for some reason it's technically
impossible to do so).

[chkneo]

Attaching the test patch

[orsenthil]

Fixed in r86450 (py3k). Will be back porting shortly.

[orsenthil]

r86461 (release31-maint)
r86462 (release27-maint)