Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mimetype for image/vnd.microsoft.icon (patch) #49551

Closed
adhintz mannequin opened this issue Feb 17, 2009 · 8 comments
Closed

add mimetype for image/vnd.microsoft.icon (patch) #49551

adhintz mannequin opened this issue Feb 17, 2009 · 8 comments
Assignees
Labels
stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error

Comments

@adhintz
Copy link
Mannequin

adhintz mannequin commented Feb 17, 2009

BPO 5301
Nosy @merwok, @sandrotosi
Files
  • mimetypes.py.diff: add mimetype for image/vnd.microsoft.icon
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/sandrotosi'
    closed_at = <Date 2012-03-27.01:09:16.400>
    created_at = <Date 2009-02-17.21:56:30.348>
    labels = ['type-bug', 'library']
    title = 'add mimetype for image/vnd.microsoft.icon (patch)'
    updated_at = <Date 2012-03-27.01:09:16.399>
    user = 'https://bugs.python.org/adhintz'

    bugs.python.org fields:

    activity = <Date 2012-03-27.01:09:16.399>
    actor = 'r.david.murray'
    assignee = 'sandro.tosi'
    closed = True
    closed_date = <Date 2012-03-27.01:09:16.400>
    closer = 'r.david.murray'
    components = ['Library (Lib)']
    creation = <Date 2009-02-17.21:56:30.348>
    creator = 'adhintz'
    dependencies = []
    files = ['13125']
    hgrepos = []
    issue_num = 5301
    keywords = ['patch']
    message_count = 8.0
    messages = ['82373', '109753', '142575', '142576', '143474', '147017', '156540', '156889']
    nosy_count = 5.0
    nosy_names = ['eric.araujo', 'adhintz', 'sandro.tosi', 'BreamoreBoy', 'python-dev']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue5301'
    versions = ['Python 2.7', 'Python 3.2', 'Python 3.3']

    @adhintz
    Copy link
    Mannequin Author

    adhintz mannequin commented Feb 17, 2009

    Adds a mimetype entry for image/vnd.microsoft.icon

    This mimetype is commonly used for favicon.ico files and is registered
    with IANA.

    @adhintz adhintz mannequin added stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error labels Feb 17, 2009
    @BreamoreBoy
    Copy link
    Mannequin

    BreamoreBoy mannequin commented Jul 9, 2010

    Just a one line addition to mimetypes.py

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Aug 20, 2011

    New changeset 4964215ddcba by Sandro Tosi in branch '2.7':
    bpo-5301: add image/vnd.microsoft.icon (.ico) MIME type
    http://hg.python.org/cpython/rev/4964215ddcba

    New changeset d9a0781c24b8 by Sandro Tosi in branch '3.2':
    bpo-5301: add image/vnd.microsoft.icon (.ico) MIME type
    http://hg.python.org/cpython/rev/d9a0781c24b8

    New changeset 95b230772469 by Sandro Tosi in branch 'default':
    bpo-5301: merge with 3.2
    http://hg.python.org/cpython/rev/95b230772469

    @sandrotosi
    Copy link
    Contributor

    Thanks Drew for the issue and the patch: it has now been committed on all the active branches!

    @sandrotosi sandrotosi self-assigned this Aug 20, 2011
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Sep 4, 2011

    New changeset cba2558b73ee by Sandro Tosi in branch '3.2':
    bpo-5301: add image/vnd.microsoft.icon (.ico) MIME type
    http://hg.python.org/cpython/rev/cba2558b73ee

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Nov 4, 2011

    New changeset 33680de042e7 by Éric Araujo in branch '2.7':
    Revert commit that was not a bugfix (bpo-5301).
    http://hg.python.org/cpython/rev/33680de042e7

    @merwok
    Copy link
    Member

    merwok commented Mar 22, 2012

    Reopening for 2.7. See http://bugs.python.org/issue13952#msg153106 and also Terry’s proposal in the last message.

    @merwok merwok reopened this Mar 22, 2012
    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Mar 27, 2012

    New changeset 3e7f6f931e09 by R David Murray in branch '2.7':
    bpo-5301: re-add image/vnd.microsoft.icon per discussion
    http://hg.python.org/cpython/rev/3e7f6f931e09

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    stdlib Python modules in the Lib dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants