Objects/bytesobject.c should include stringdefs.h, instead of defining its own macros

[ericvsmith]

BPO	5748
Nosy	@ericvsmith

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/ericvsmith'
closed_at = <Date 2009-11-30.01:02:16.184>
created_at = <Date 2009-04-13.21:15:08.637>
labels = ['interpreter-core', 'easy', 'type-bug']
title = 'Objects/bytesobject.c should include stringdefs.h, instead of defining its own macros'
updated_at = <Date 2009-11-30.01:02:16.183>
user = 'https://github.com/ericvsmith'

bugs.python.org fields:

activity = <Date 2009-11-30.01:02:16.183>
actor = 'eric.smith'
assignee = 'eric.smith'
closed = True
closed_date = <Date 2009-11-30.01:02:16.184>
closer = 'eric.smith'
components = ['Interpreter Core']
creation = <Date 2009-04-13.21:15:08.637>
creator = 'eric.smith'
dependencies = []
files = []
hgrepos = []
issue_num = 5748
keywords = ['easy']
message_count = 3.0
messages = ['85954', '95828', '95829']
nosy_count = 2.0
nosy_names = ['eric.smith', 'victorpoluceno']
pr_nums = []
priority = 'normal'
resolution = 'accepted'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue5748'
versions = ['Python 3.2']

[ericvsmith]

All of the macros it defines around line 565 should either already be in
stringdefs.h, or they should be added there.

The same issue exists in Objects/bytearrayobject.c. I haven't looked in
2.7, but I assume the same problem exists there.

[ericvsmith]

This does not apply to 2.x. In both py3k and trunk,
Objects/bytearrayobject.c uses stringlib with some private defines. But
since those defines are only used in bytearrayobject.c, there's nothing
to be gained by factoring then out into a bytearraydef.h file.

So, I'm just going to fix this in Objects/bytesobjects.c, which only
appears in py3k.

[ericvsmith]

Fixed in r76595.