Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

marshal.c needs to be checked for out of memory errors #50025

Closed
ericvsmith opened this issue Apr 16, 2009 · 2 comments
Closed

marshal.c needs to be checked for out of memory errors #50025

ericvsmith opened this issue Apr 16, 2009 · 2 comments
Assignees
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage release-blocker

Comments

@ericvsmith
Copy link
Member

BPO 5775
Nosy @ericvsmith

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/ericvsmith'
closed_at = <Date 2009-04-21.11:58:04.523>
created_at = <Date 2009-04-16.22:07:46.725>
labels = ['interpreter-core', 'release-blocker', 'performance']
title = 'marshal.c needs to be checked for out of memory errors'
updated_at = <Date 2009-04-21.11:58:04.495>
user = 'https://github.com/ericvsmith'

bugs.python.org fields:

activity = <Date 2009-04-21.11:58:04.495>
actor = 'eric.smith'
assignee = 'eric.smith'
closed = True
closed_date = <Date 2009-04-21.11:58:04.523>
closer = 'eric.smith'
components = ['Interpreter Core']
creation = <Date 2009-04-16.22:07:46.725>
creator = 'eric.smith'
dependencies = []
files = []
hgrepos = []
issue_num = 5775
keywords = []
message_count = 2.0
messages = ['86049', '86228']
nosy_count = 1.0
nosy_names = ['eric.smith']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue5775'
versions = ['Python 3.1']

@ericvsmith
Copy link
Member Author

With the changes in r71665, w_object() in marshal.c needs to be checked
for out of memory errors when converting floats to strings. I'm not
convinced the existing error checking was correct, but I haven't spent a
lot of time looking at it.

The fact that w_object() is recursive makes the problem that much tougher.

I'll get to this before the next 3.1 release.

@ericvsmith ericvsmith self-assigned this Apr 16, 2009
@ericvsmith ericvsmith added interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage labels Apr 16, 2009
@ericvsmith
Copy link
Member Author

Fixed in r71783.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) performance Performance or resource usage release-blocker
Projects
None yet
Development

No branches or pull requests

1 participant