Use shipped zlib if the system version is bad

[devdanzin]

BPO	6016
Nosy	@devdanzin
Files	zlib_setup.diff: Patch against trunk, seems to apply fine on py3k.

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2009-05-14.03:33:22.800>
created_at = <Date 2009-05-14.02:05:46.172>
labels = ['type-feature', 'invalid', 'build']
title = 'Use shipped zlib if the system version is bad'
updated_at = <Date 2009-05-14.03:33:22.605>
user = 'https://github.com/devdanzin'

bugs.python.org fields:

activity = <Date 2009-05-14.03:33:22.605>
actor = 'ajaksu2'
assignee = 'none'
closed = True
closed_date = <Date 2009-05-14.03:33:22.800>
closer = 'ajaksu2'
components = ['Build']
creation = <Date 2009-05-14.02:05:46.172>
creator = 'ajaksu2'
dependencies = []
files = ['13980']
hgrepos = []
issue_num = 6016
keywords = ['patch']
message_count = 2.0
messages = ['87727', '87728']
nosy_count = 1.0
nosy_names = ['ajaksu2']
pr_nums = []
priority = 'normal'
resolution = 'not a bug'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue6016'
versions = ['Python 2.7', 'Python 3.2']

[devdanzin]

The attached patch makes setup.py use the shipped zlib.h in
Modules/zlib/ when a bogus zlib.h is found by find_file.

However, I couldn't test it (nor make it work) when a system zlib is
missing (no time right now). Can we build the shipped zlib and link
against it?

[devdanzin]

We'd be asking for trouble with this: incompatible shipped and system
versions or having to build the shipped version. All that for working
around the rare case where the user doesn't have a valid zlib makes no
sense :)