Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2to3 misses buffer slicing #50435

Closed
joeamenta mannequin opened this issue Jun 3, 2009 · 3 comments
Closed

2to3 misses buffer slicing #50435

joeamenta mannequin opened this issue Jun 3, 2009 · 3 comments
Assignees
Labels
topic-2to3 type-bug An unexpected behavior, bug, or error

Comments

@joeamenta
Copy link
Mannequin

joeamenta mannequin commented Jun 3, 2009

BPO 6185
Nosy @benjaminp
Files
  • buffertest.patch: This test will fail on the current revision.
  • bufferfix.patch: This patch will fix the problem and pass the test.
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/benjaminp'
    closed_at = <Date 2009-06-03.18:10:23.576>
    created_at = <Date 2009-06-03.05:36:24.027>
    labels = ['type-bug', 'expert-2to3']
    title = '2to3 misses buffer slicing'
    updated_at = <Date 2009-06-03.18:10:23.574>
    user = 'https://bugs.python.org/joeamenta'

    bugs.python.org fields:

    activity = <Date 2009-06-03.18:10:23.574>
    actor = 'benjamin.peterson'
    assignee = 'benjamin.peterson'
    closed = True
    closed_date = <Date 2009-06-03.18:10:23.576>
    closer = 'benjamin.peterson'
    components = ['2to3 (2.x to 3.x conversion tool)']
    creation = <Date 2009-06-03.05:36:24.027>
    creator = 'joe.amenta'
    dependencies = []
    files = ['14164', '14165']
    hgrepos = []
    issue_num = 6185
    keywords = ['patch']
    message_count = 3.0
    messages = ['88795', '88796', '88821']
    nosy_count = 2.0
    nosy_names = ['benjamin.peterson', 'joe.amenta']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = None
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue6185'
    versions = ['Python 2.7']

    @joeamenta
    Copy link
    Mannequin Author

    joeamenta mannequin commented Jun 3, 2009

    Found this bug while writing the backwards version of this fix for
    3to2... there is no test for it, so it went undetected. The PATTERN
    does not match a buffer() invocation if there is a token after the
    rparen, i.e. slicing.

    @joeamenta joeamenta mannequin added topic-2to3 type-bug An unexpected behavior, bug, or error labels Jun 3, 2009
    @joeamenta
    Copy link
    Mannequin Author

    joeamenta mannequin commented Jun 3, 2009

    Patch that will fix the problem (and make the test pass)

    @benjaminp benjaminp self-assigned this Jun 3, 2009
    @benjaminp
    Copy link
    Contributor

    Thanks for the patch! Fixed in r73179.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    topic-2to3 type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant