Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2to3 except fixer failed in certain case #50471

Closed
bhy mannequin opened this issue Jun 6, 2009 · 2 comments
Closed

2to3 except fixer failed in certain case #50471

bhy mannequin opened this issue Jun 6, 2009 · 2 comments

Comments

@bhy
Copy link
Mannequin

bhy mannequin commented Jun 6, 2009

BPO 6222
Nosy @benjaminp

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2009-06-06.16:24:02.471>
created_at = <Date 2009-06-06.16:11:52.227>
labels = ['expert-2to3']
title = '2to3 except fixer failed in certain case'
updated_at = <Date 2009-06-06.16:24:02.469>
user = 'https://bugs.python.org/bhy'

bugs.python.org fields:

activity = <Date 2009-06-06.16:24:02.469>
actor = 'benjamin.peterson'
assignee = 'none'
closed = True
closed_date = <Date 2009-06-06.16:24:02.471>
closer = 'benjamin.peterson'
components = ['2to3 (2.x to 3.x conversion tool)']
creation = <Date 2009-06-06.16:11:52.227>
creator = 'bhy'
dependencies = []
files = []
hgrepos = []
issue_num = 6222
keywords = []
message_count = 2.0
messages = ['89005', '89006']
nosy_count = 2.0
nosy_names = ['benjamin.peterson', 'bhy']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue6222'
versions = ['Python 2.6', 'Python 3.0', 'Python 3.1']

@bhy
Copy link
Mannequin Author

bhy mannequin commented Jun 6, 2009

The 2to3 except fixer will be failed with this code:

try: raise TypeError
except TypeError, x:
pass

with this code, 2to3 will produce an empty diff, i.e. it fixes nothing.

But when change it to the following, 2to3 works again:

try:
raise TypeError
except TypeError, x:
pass

with this, 2to3 will provide a correct diff.

@bhy bhy mannequin added the topic-2to3 label Jun 6, 2009
@benjaminp
Copy link
Contributor

Fixed in r73255.

@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant