Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No such file or directory: 'msisupport.dll' in msi.py #51056

Closed
pds mannequin opened this issue Aug 30, 2009 · 7 comments
Closed

No such file or directory: 'msisupport.dll' in msi.py #51056

pds mannequin opened this issue Aug 30, 2009 · 7 comments
Labels
OS-windows topic-installation type-bug An unexpected behavior, bug, or error

Comments

@pds
Copy link
Mannequin

pds mannequin commented Aug 30, 2009

BPO 6807
Nosy @loewis, @briancurtin
Files
  • patch.txt
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2012-02-21.17:12:37.857>
    created_at = <Date 2009-08-30.10:59:14.901>
    labels = ['type-bug', 'expert-installation', 'OS-windows']
    title = "No such file or directory: 'msisupport.dll' in msi.py"
    updated_at = <Date 2012-02-21.17:12:37.855>
    user = 'https://bugs.python.org/pds'

    bugs.python.org fields:

    activity = <Date 2012-02-21.17:12:37.855>
    actor = 'loewis'
    assignee = 'none'
    closed = True
    closed_date = <Date 2012-02-21.17:12:37.857>
    closer = 'loewis'
    components = ['Installation', 'Windows']
    creation = <Date 2009-08-30.10:59:14.901>
    creator = 'pds'
    dependencies = []
    files = ['14806']
    hgrepos = []
    issue_num = 6807
    keywords = []
    message_count = 7.0
    messages = ['92086', '110006', '110012', '145395', '153879', '153880', '153881']
    nosy_count = 6.0
    nosy_names = ['loewis', 'sable', 'brian.curtin', 'pds', 'BreamoreBoy', 'python-dev']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'patch review'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue6807'
    versions = ['Python 3.1', 'Python 2.7', 'Python 3.2']

    @pds
    Copy link
    Mannequin Author

    pds mannequin commented Aug 30, 2009

    Investigating the issue bpo-6716 I reported earlier, I've been trying to
    build Windows MSI installer package of Python 3.1 on my own.
    I checked out the svn source, built things with Visual C++ 2008 Express
    Edition, and tried to make MSI package in Tools\msi directory.
    When I run Tools\msi\msi.py in Tools\msi directory, the following error
    occurs:

    Traceback (most recent call last):
      File "msi.py", line 178, in <module>
        if msilib.pe_type(dll_path) != msilib.pe_type("msisupport.dll"):
      File "E:\python31svnbuild\Tools\msi\msilib.py", line 665, in pe_type
        header = open(path, "rb").read(1000)
    IOError: [Errno 2] No such file or directory: 'msisupport.dll'

    It seems that msilib.pe_type("msisupport.dll") is called before
    msisupport.dll is created.
    I read msi.py and learned that msilib.pe_type("msisupport.dll") (line
    178) is executed before os.system("nmake /nologo /c /f msisupport.mak")
    (line 372) is executed in add_ui(), which is called at line 1299.
    So I made a patch to make msi.py to see if the file "msisupport.dll"
    exists, and if it does, check if the dll is for the correct architecture.

    @pds pds mannequin added topic-installation type-bug An unexpected behavior, bug, or error labels Aug 30, 2009
    @larryhastings
    Copy link
    Contributor

    Why did you assign this to me? I don't know why my name is on this bug in the first place.

    Is it possible you were thinking of another Larry?

    @BreamoreBoy
    Copy link
    Mannequin

    BreamoreBoy mannequin commented Jul 11, 2010

    I didn't realise that I had, sorry!!!

    @BreamoreBoy BreamoreBoy mannequin unassigned larryhastings Jul 11, 2010
    @sable
    Copy link
    Mannequin

    sable mannequin commented Oct 12, 2011

    I had the same issue today. The patch solved the problem.
    Thanks

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 21, 2012

    New changeset bc66484b0d73 by Martin v. Löwis in branch '3.2':
    Issue bpo-6807: Run msisupport.mak earlier.
    http://hg.python.org/cpython/rev/bc66484b0d73

    @python-dev
    Copy link
    Mannequin

    python-dev mannequin commented Feb 21, 2012

    New changeset e78acdb54841 by Martin v. Löwis in branch '2.7':
    Issue bpo-6807: Run msisupport.mak earlier.
    http://hg.python.org/cpython/rev/e78acdb54841

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Feb 21, 2012

    This is now fixed, though in a different way.

    @loewis loewis mannequin closed this as completed Feb 21, 2012
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    OS-windows topic-installation type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants