Patch for get_filename in email.message when content-disposition is missing

[DazWorrall]

BPO	7082
Nosy	@warsaw, @bitdancer
Files	message-getfilename.patch: Patch against 2.7 trunk

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/bitdancer'
closed_at = <Date 2009-10-27.23:42:47.088>
created_at = <Date 2009-10-08.12:38:33.522>
labels = ['type-bug', 'library']
title = 'Patch for get_filename in email.message when content-disposition is missing'
updated_at = <Date 2009-10-27.23:42:47.087>
user = 'https://bugs.python.org/DazWorrall'

bugs.python.org fields:

activity = <Date 2009-10-27.23:42:47.087>
actor = 'r.david.murray'
assignee = 'r.david.murray'
closed = True
closed_date = <Date 2009-10-27.23:42:47.088>
closer = 'r.david.murray'
components = ['Library (Lib)']
creation = <Date 2009-10-08.12:38:33.522>
creator = 'DazWorrall'
dependencies = []
files = ['15080']
hgrepos = []
issue_num = 7082
keywords = ['patch']
message_count = 6.0
messages = ['93743', '93744', '93759', '93783', '93816', '94593']
nosy_count = 3.0
nosy_names = ['barry', 'r.david.murray', 'DazWorrall']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue7082'
versions = ['Python 2.6', 'Python 3.1', 'Python 2.7', 'Python 3.2']

[DazWorrall]

Finger spasm submitted this without a comment, apologies.

I believe the fix applied in http://bugs.python.org/issue1403349 is not
actually correct. In the case where Content-Disposition is missing, the
'name' parameter should be on Content-Type - but the original patch
looks for 'name' on Content-Disposition, which doesn't exist.

[DazWorrall]

Patch is against 2.7 trunk, but should backport without any resistance.

[bitdancer]

2.4 and 2.5 are open only for security patches, which this is not, so
I've removed them from versions, and added 3.1 and 3.2, which have the
same code.

The patch looks appropriate to me, and is what the original bug report
requested.

Note that the Content-Type name parameter has been deprecated for a long
time...see for example this thread:
http://www.imc.org/ietf-822/old-archive2/msg02121.html. Support is
still required, however, since Microsoft's .NET framework, at least,
still supports setting the parameter (see
http://msdn.microsoft.com/en-us/library/system.net.mime.contenttype.name.aspx)

[DazWorrall]

Indeed, I'm certainly not constructing messages like that, but
occasionally have to process them :)

RE: the python versions, I'll remember that in future, thanks.

[bitdancer]

Applied to trunk in r75301, py3k in r75307, and 3.1 in r75308. Leaving
open until I can backport it to 2.6. Thanks, Darren.

[bitdancer]

Fixed in 2.6 in r75897.