Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseHTTPServer.BaseHTTPRequestHandler.responses[405] has a small mistake #51421

Closed
dalke mannequin opened this issue Oct 19, 2009 · 3 comments
Closed

BaseHTTPServer.BaseHTTPRequestHandler.responses[405] has a small mistake #51421

dalke mannequin opened this issue Oct 19, 2009 · 3 comments
Assignees
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@dalke
Copy link
Mannequin

dalke mannequin commented Oct 19, 2009

BPO 7172
Nosy @orsenthil

Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

Show more details

GitHub fields:

assignee = 'https://github.com/orsenthil'
closed_at = <Date 2010-02-22.11:03:46.352>
created_at = <Date 2009-10-19.23:40:16.046>
labels = ['type-feature', 'library']
title = 'BaseHTTPServer.BaseHTTPRequestHandler.responses[405] has a small mistake'
updated_at = <Date 2010-02-22.11:03:46.210>
user = 'https://bugs.python.org/dalke'

bugs.python.org fields:

activity = <Date 2010-02-22.11:03:46.210>
actor = 'orsenthil'
assignee = 'orsenthil'
closed = True
closed_date = <Date 2010-02-22.11:03:46.352>
closer = 'orsenthil'
components = ['Library (Lib)']
creation = <Date 2009-10-19.23:40:16.046>
creator = 'dalke'
dependencies = []
files = []
hgrepos = []
issue_num = 7172
keywords = []
message_count = 3.0
messages = ['94262', '94263', '99719']
nosy_count = 2.0
nosy_names = ['dalke', 'orsenthil']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = None
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue7172'
versions = ['Python 2.6', 'Python 3.1', 'Python 2.7', 'Python 3.2']

@dalke
Copy link
Mannequin Author

dalke mannequin commented Oct 19, 2009

BaseHTTPServer.BaseHTTPRequestHandler.responses contains a mapping from
HTTP status codes to the 2-ple (shortmessage, longmessage), based on RFC
2616.

The 2-ple for 405 is ('Method Not Allowed','Specified method is invalid
for this server.'),

RFC 405 says "An origin server SHOULD return the status code 405 (Method
Not Allowed) if the method is known by the origin server but not allowed
for the requested resource.

I think the message should be "Specified method is invalid for this
resource". That is, change "server" to "resource".

@dalke dalke mannequin added stdlib Python modules in the Lib dir type-feature A feature request or enhancement labels Oct 19, 2009
@dalke
Copy link
Mannequin Author

dalke mannequin commented Oct 20, 2009

Wasn't thinking. I'm not quoting from "RFC 405", I'm quoting the 405
section from RFC 2616.

@orsenthil
Copy link
Member

Verified in the rfc.
Fixed and committed in revision 78299 and merged into other branches.

@orsenthil orsenthil self-assigned this Feb 22, 2010
@ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement
Projects
None yet
Development

No branches or pull requests

1 participant