Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test cases for bool #52495

Closed
gnofi mannequin opened this issue Mar 28, 2010 · 4 comments
Closed

Add test cases for bool #52495

gnofi mannequin opened this issue Mar 28, 2010 · 4 comments
Labels
tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@gnofi
Copy link
Mannequin

gnofi mannequin commented Mar 28, 2010

BPO 8248
Nosy @pitrou, @ezio-melotti, @DinoV
Files
  • test_bool.v2.patch: 2.x trunk patch
  • test_bool.v3.patch: 3.x trunk patch
  • test_bool.v2.patch: Updated 2.x trunk patch w/ test_bool, decimal, index
  • test_bool.v3.patch: Updated 3.x branch patch w/ test_bool, decimal, index
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2010-03-30.19:01:00.057>
    created_at = <Date 2010-03-28.03:03:11.521>
    labels = ['type-bug', 'tests']
    title = 'Add test cases for bool'
    updated_at = <Date 2010-03-30.19:01:00.055>
    user = 'https://bugs.python.org/gnofi'

    bugs.python.org fields:

    activity = <Date 2010-03-30.19:01:00.055>
    actor = 'pitrou'
    assignee = 'none'
    closed = True
    closed_date = <Date 2010-03-30.19:01:00.057>
    closer = 'pitrou'
    components = ['Tests']
    creation = <Date 2010-03-28.03:03:11.521>
    creator = 'gnofi'
    dependencies = []
    files = ['16677', '16678', '16684', '16685']
    hgrepos = []
    issue_num = 8248
    keywords = ['patch']
    message_count = 4.0
    messages = ['101853', '101877', '101883', '101952']
    nosy_count = 4.0
    nosy_names = ['pitrou', 'ezio.melotti', 'dino.viehland', 'gnofi']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue8248'
    versions = ['Python 2.7', 'Python 3.2']

    @gnofi
    Copy link
    Mannequin Author

    gnofi mannequin commented Mar 28, 2010

    These patches add these new test cases to test_bool.py.

    Python 2+3:

    • Conversion to float
    • Conversion to Decimal
    • Calling bool() of built-in types

    Python 2 only:

    • __index__()
    • Conversion to long
    • sprintf formatting

    NOTE: I'm currently helping Dino Viehland port IronPython tests into CPython. This is the first of that series.

    @gnofi gnofi mannequin added tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error labels Mar 28, 2010
    @pitrou
    Copy link
    Member

    pitrou commented Mar 28, 2010

    Decimal tests should probably be in test_decimal, not test_bool.
    Also, I'm not sure why the __index__ and format tests aren't in the py3k patch.

    @gnofi
    Copy link
    Mannequin Author

    gnofi mannequin commented Mar 29, 2010

    Indeed, the Decimal test is better off in test_decimal.DecimalExplicitConstructionTest so I moved it there.

    I forgot to include the index test for the py3k patch. That's in the updated patch, too.

    There is already a format test in the py3k branch.

    @pitrou
    Copy link
    Member

    pitrou commented Mar 30, 2010

    Committed in r79502, r79504 (trunk) and r79503 (py3k). Thank you!

    @pitrou pitrou closed this as completed Mar 30, 2010
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant