add a distutils test command

[tarekziade]

BPO	8324
Nosy	@warsaw, @giampaolo, @tarekziade, @merwok, @voidspace

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/tarekziade'
closed_at = <Date 2010-09-07.15:18:51.873>
created_at = <Date 2010-04-05.23:19:32.568>
labels = ['type-feature']
title = 'add a distutils test command'
updated_at = <Date 2010-09-07.15:18:51.850>
user = 'https://github.com/tarekziade'

bugs.python.org fields:

activity = <Date 2010-09-07.15:18:51.850>
actor = 'eric.araujo'
assignee = 'tarek'
closed = True
closed_date = <Date 2010-09-07.15:18:51.873>
closer = 'eric.araujo'
components = ['Distutils2']
creation = <Date 2010-04-05.23:19:32.568>
creator = 'tarek'
dependencies = []
files = []
hgrepos = []
issue_num = 8324
keywords = ['gsoc']
message_count = 13.0
messages = ['102426', '102427', '105362', '105376', '105382', '105383', '105384', '105386', '105389', '105390', '105393', '105418', '115773']
nosy_count = 8.0
nosy_names = ['barry', 'giampaolo.rodola', 'tarek', 'eric.araujo', 'michael.foord', 'konryd', 'meatballhat', 'zubin71']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue8324'
versions = ['Python 2.6', 'Python 2.5', 'Python 3.1', 'Python 2.7', 'Python 3.2']

[tarekziade]

Add a test command in distutils, ala setuptools

[voidspace]

Should default to test discovery if no arguments are supplied.

Valid arguments: "testrunner", "tests" or "testsuite".
Default testrunner is unittest of course. "tests" / "testsuite" to be of the form: "package.module.suitename" (or just "package.module").

[meatballhat]

For what it's worth, I'm trying to adapt the setuptools command of the same name in a feature branch called "mbh/adding-test-command" --> http://bitbucket.org/meatballhat/distutils2/

Not sure how the roundup/<external tracker> split is usually handled, so sorry if I'm doin it wrong :-/

[voidspace]

Adapting the setuptools command is a great way to start of course. Please see my note about using unittest/unittest2 test discovery as a default command if unitest2 is available and no test_suite is specified. I'm very happy to help with this.

[meatballhat]

Should I assume that unittest2 is an installation requirement of distutils2, or is it preferable to try using unittest2 and falling back to a custom TestLoader? Sorry if I'm reading too much into this :-/

[merwok]

unittest2 is the name of the independent release of the improved unittest package in 2.7’s and 3.2’s stdlib.

[meatballhat]

@merwok I know ;-) ... should I assume that it's an installation requirement a la install_requires=['unittest2'], or do::

try:
    load_tests_with_unittest2()
except ImportError:
    load_tests_with_custom_test_loader()

?

[merwok]

Not a unittest expert, but I suspect that usual test for features will work:

try:
from unittest.something.discovery import Loader
except ImportError:
from unittest2.something.discovery import Loader

Adding Konrad to nosy, since adding new commands will be his GSoC work.

(Also adjusting versions and removing the gsoc keyword that means “Issue is a good candidate for Google’s Summer of Code”, not “Issue part of an accepted GSoC project”)

[voidspace]

unittest2 is used for distutils2 development, but *not* a required dependency for *using* distutils2 (if I understand correctly(.

Well, if there is no test runner and no test suite specified but the test command is invoked then the steps should probably be something like:

• If Python version 2.7+ or 3.2+ then use test discovery from unittest
• If Python version 3.0, 3.1 or 2.6- then attempt to import unittest2 and do test discovery
• Otherwise do nothing

Test discovery is done with unittest(2).TestLoader.discover(...)

If a specific test runner or suite is provided then distutils2 should use those and need not attempt test discovery (again - my understanding).

So test discovery is a useful default if no test command is configured for a project. We may also want ways to configure that (for example allow a project to have test discovery for its test command but provide a different pattern for finding test files).

[voidspace]

Documentation for unittest.TestLoader.discover(...) is at:

http://docs.python.org/dev/library/unittest.html#unittest.TestLoader.discover

[meatballhat]

@mfoord thank you for the clarification! :)

[tarekziade]

@eric: I asked for the gsoc keyword to make my work easier in bug triage. And as a matter of fact, it means that the issue part of the GSoC.

[merwok]

Implemented by Konrad and merged into the main repo.