Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build-installer fix for doc building on OSX 10.4 #52721

Closed
db3l opened this issue Apr 20, 2010 · 3 comments
Closed

build-installer fix for doc building on OSX 10.4 #52721

db3l opened this issue Apr 20, 2010 · 3 comments
Assignees
Labels
build The build process and cross-build OS-mac

Comments

@db3l
Copy link
Contributor

db3l commented Apr 20, 2010

BPO 8475
Nosy @loewis, @db3l, @ronaldoussoren
Files
  • build-installer.diff
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/ronaldoussoren'
    closed_at = <Date 2010-04-22.13:18:27.804>
    created_at = <Date 2010-04-20.22:53:23.029>
    labels = ['OS-mac', 'build']
    title = 'build-installer fix for doc building on OSX 10.4'
    updated_at = <Date 2010-04-22.13:18:27.802>
    user = 'https://github.com/db3l'

    bugs.python.org fields:

    activity = <Date 2010-04-22.13:18:27.802>
    actor = 'loewis'
    assignee = 'ronaldoussoren'
    closed = True
    closed_date = <Date 2010-04-22.13:18:27.804>
    closer = 'loewis'
    components = ['macOS']
    creation = <Date 2010-04-20.22:53:23.029>
    creator = 'db3l'
    dependencies = []
    files = ['17014']
    hgrepos = []
    issue_num = 8475
    keywords = ['patch']
    message_count = 3.0
    messages = ['103790', '103954', '103963']
    nosy_count = 3.0
    nosy_names = ['loewis', 'db3l', 'ronaldoussoren']
    pr_nums = []
    priority = 'normal'
    resolution = 'accepted'
    stage = None
    status = 'closed'
    superseder = None
    type = 'compile error'
    url = 'https://bugs.python.org/issue8475'
    versions = ['Python 2.6', 'Python 3.1', 'Python 2.7', 'Python 3.2', 'Python 3.3']

    @db3l
    Copy link
    Contributor Author

    db3l commented Apr 20, 2010

    The attached suggested patch changes build-installer to pass along the same Python executable that it itself is running under to the documentation Makefile. This fixes an issue on OSX where pruning the PATH reverts to the system python (2.3.5) which is too old for Sphinx.

    This does now mean that build-installer itself needs to be run under 2.5+ which contradicts its initial usage comments. I suspect we should just give up supporting it under 2.3, since an underlying tool no longer supports that, but have not changed those comments in this patch

    @db3l db3l added OS-mac build The build process and cross-build labels Apr 20, 2010
    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Apr 22, 2010

    Thanks for the patch. Committed as r80355-

    @loewis
    Copy link
    Mannequin

    loewis mannequin commented Apr 22, 2010

    It seems to work fine, so merged as r80365, r80366, r80367.

    @loewis loewis mannequin closed this as completed Apr 22, 2010
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    build The build process and cross-build OS-mac
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants