Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audioop module needs an int -> Py_ssize_t upgrade #52921

Closed
mdickinson opened this issue May 10, 2010 · 3 comments
Closed

audioop module needs an int -> Py_ssize_t upgrade #52921

mdickinson opened this issue May 10, 2010 · 3 comments
Labels
easy extension-modules C modules in the Modules dir performance Performance or resource usage

Comments

@mdickinson
Copy link
Member

BPO 8675
Nosy @mdickinson
Files
  • audioop_Py_ssize_t.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2010-05-11.13:35:12.709>
    created_at = <Date 2010-05-10.18:38:03.354>
    labels = ['extension-modules', 'easy', 'performance']
    title = 'audioop module needs an int -> Py_ssize_t upgrade'
    updated_at = <Date 2010-05-11.13:35:12.707>
    user = 'https://github.com/mdickinson'

    bugs.python.org fields:

    activity = <Date 2010-05-11.13:35:12.707>
    actor = 'mark.dickinson'
    assignee = 'none'
    closed = True
    closed_date = <Date 2010-05-11.13:35:12.709>
    closer = 'mark.dickinson'
    components = ['Extension Modules']
    creation = <Date 2010-05-10.18:38:03.354>
    creator = 'mark.dickinson'
    dependencies = []
    files = ['17294']
    hgrepos = []
    issue_num = 8675
    keywords = ['patch', 'easy']
    message_count = 3.0
    messages = ['105454', '105506', '105511']
    nosy_count = 1.0
    nosy_names = ['mark.dickinson']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'performance'
    url = 'https://bugs.python.org/issue8675'
    versions = ['Python 3.2']

    @mdickinson
    Copy link
    Member Author

    The audioop module still uses 'int' for most of its sizes; it would be better if it used 'Py_ssize_t' instead, so that data aren't artificially limited to 2Gb on 64-bit systems.

    Converting ought to be a fairly straightforward task for someone wanting to get their feet wet with CPython hacking; marking as easy.

    @mdickinson mdickinson added easy performance Performance or resource usage labels May 10, 2010
    @mdickinson
    Copy link
    Member Author

    Here's a patch.

    @mdickinson
    Copy link
    Member Author

    The audioop module was made PY_SSIZE_T_CLEAN in r81083.

    @mdickinson mdickinson added the extension-modules C modules in the Modules dir label May 11, 2010
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    easy extension-modules C modules in the Modules dir performance Performance or resource usage
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant