Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 391: Adding documentation of logging.config.dictConfig #52943

Closed
akuchling opened this issue May 12, 2010 · 1 comment
Closed

PEP 391: Adding documentation of logging.config.dictConfig #52943

akuchling opened this issue May 12, 2010 · 1 comment
Assignees
Labels
docs Documentation in the Doc dir

Comments

@akuchling
Copy link
Member

BPO 8697
Nosy @akuchling, @vsajip
Files
  • pep391-docs.txt: Patch v1
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = 'https://github.com/vsajip'
    closed_at = <Date 2010-05-12.14:29:00.821>
    created_at = <Date 2010-05-12.14:27:09.918>
    labels = ['docs']
    title = 'PEP 391: Adding documentation of logging.config.dictConfig'
    updated_at = <Date 2010-05-12.14:29:00.820>
    user = 'https://github.com/akuchling'

    bugs.python.org fields:

    activity = <Date 2010-05-12.14:29:00.820>
    actor = 'akuchling'
    assignee = 'vinay.sajip'
    closed = True
    closed_date = <Date 2010-05-12.14:29:00.821>
    closer = 'akuchling'
    components = ['Documentation']
    creation = <Date 2010-05-12.14:27:09.918>
    creator = 'akuchling'
    dependencies = []
    files = ['17307']
    hgrepos = []
    issue_num = 8697
    keywords = ['patch', 'needs review']
    message_count = 1.0
    messages = ['105588']
    nosy_count = 2.0
    nosy_names = ['akuchling', 'vinay.sajip']
    pr_nums = []
    priority = 'low'
    resolution = 'duplicate'
    stage = 'patch review'
    status = 'closed'
    superseder = None
    type = None
    url = 'https://bugs.python.org/issue8697'
    versions = ['Python 2.7']

    @akuchling
    Copy link
    Member Author

    The attached patch adds a first cut at documenting the PEP-391 dictConfig() feature. I've taken the PEP-391 text and rearranged it to fit into the existing logging module docs. I haven't gone through every paragraph and adjusted the markup to use Sphinx roles.

    Vinay: I don't think you need to proofread every single bit of text in this patch. I suggest you look at the following things:

    • The start of the 'Configuring Logging' section, which I rewrote.

    • The description of dictConfig(), which is assembled from several bits of the PEP.

    • The details of the dictionary schema are moved to be first instead of last. I therefore rewrote the paragraph in the PEP beginning "Before describing the schema in detail..." to one that begins "Describing a logging configuration requires listing..." Is the new paragraph OK?

    If you like the resulting ordering and the rewritten text, then I'll go through the rest of the text adding Sphinx markup, and commit the result.

    Thanks!

    @akuchling akuchling added the docs Documentation in the Doc dir label May 12, 2010
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    docs Documentation in the Doc dir
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants