set_contains, etc. should check for collections.Set in addition to PySet_Check

[stutzbach]

BPO	8752
Nosy	@rhettinger

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2010-05-18.19:50:52.431>
created_at = <Date 2010-05-18.15:21:11.080>
labels = ['interpreter-core', 'type-bug']
title = 'set_contains, etc. should check for collections.Set in addition to PySet_Check'
updated_at = <Date 2010-05-18.19:50:52.374>
user = 'https://bugs.python.org/stutzbach'

bugs.python.org fields:

activity = <Date 2010-05-18.19:50:52.374>
actor = 'rhettinger'
assignee = 'none'
closed = True
closed_date = <Date 2010-05-18.19:50:52.431>
closer = 'rhettinger'
components = ['Interpreter Core']
creation = <Date 2010-05-18.15:21:11.080>
creator = 'stutzbach'
dependencies = []
files = []
hgrepos = []
issue_num = 8752
keywords = []
message_count = 2.0
messages = ['105983', '106004']
nosy_count = 2.0
nosy_names = ['rhettinger', 'stutzbach']
pr_nums = []
priority = 'normal'
resolution = 'wont fix'
stage = 'test needed'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue8752'
versions = ['Python 2.7', 'Python 3.2']

[stutzbach]

For operations that test membership in a set, Python coerces sets and subclasses of set into a temporary frozenset before testing membership.

For example, this works:

>>> set() in set([frozenset()])
True

Although the set() is not hashable itself, Python creates a temporary frozenset() out of the set(). It should do the same for user-types derived from collections.Set, so they can inter-operate in the same way.

In setobject.c, the following methods behave in the described manner: set_contains, set_remove, and set_discard.

[rhettinger]

I don't think the set methods can make assumptions about whether instances of the Set API can be made frozen. It is okay to restrict this to just instances of "set" where we know its internal structure and know that its elements are hashable (see the collections docs for an example of a non-hashable set).

Also, the collections.Set methods are supposed to be minimal. They are not intended to mimic every aspect of regular set objects.