zipfile.extractall always raises an OSError after successfully unzipping all files

[aymill]

BPO	9172
Nosy	@amauryfa, @ezio-melotti
Files	example_1.zip: WinZip 11.1, unencrypted.

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2010-07-29.14:00:49.042>
created_at = <Date 2010-07-05.18:37:10.111>
labels = ['type-bug']
title = 'zipfile.extractall always raises an OSError after successfully unzipping all files'
updated_at = <Date 2010-07-29.14:00:49.036>
user = 'https://bugs.python.org/aymill'

bugs.python.org fields:

activity = <Date 2010-07-29.14:00:49.036>
actor = 'BreamoreBoy'
assignee = 'none'
closed = True
closed_date = <Date 2010-07-29.14:00:49.042>
closer = 'BreamoreBoy'
components = []
creation = <Date 2010-07-05.18:37:10.111>
creator = 'aymill'
dependencies = []
files = ['17873']
hgrepos = []
issue_num = 9172
keywords = []
message_count = 6.0
messages = ['109346', '111551', '111815', '111902', '111906', '111927']
nosy_count = 6.0
nosy_names = ['amaury.forgeotdarc', 'ezio.melotti', 'ysj.ray', 'BreamoreBoy', 'aymill', 'terytkon']
pr_nums = []
priority = 'normal'
resolution = 'duplicate'
stage = None
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue9172'
versions = ['Python 2.6', 'Python 3.1', 'Python 2.7', 'Python 3.2']

[aymill]

Tried it with a variety of unencrypted zips. Zipped with WinZip 11.1. Looks like it tries to unzip a second time after it completes the first unzip.

Python 2.6.2 (release26-maint, Apr 19 2009, 01:56:41) 
[GCC 4.3.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> from zipfile import ZipFile
>>> zip = ZipFile("example_1.zip")
>>> zip.extractall()
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python2.6/zipfile.py", line 935, in extractall
    self.extract(zipinfo, path, pwd)
  File "/usr/lib/python2.6/zipfile.py", line 923, in extract
    return self._extract_member(member, path, pwd)
  File "/usr/lib/python2.6/zipfile.py", line 960, in _extract_member
    os.mkdir(targetpath)
OSError: [Errno 17] File exists: '/home/andy/projects/codedropvalidator/testdata/example'
>>>

[terytkon]

Hi!
I encountered the same problem and I debugged it a bit..
I think it not doing the entire unzipping again, but the problem is that the winzip packaged zip actually contains all file and directory entries and it fails trying to create already existing directory (because the dir has been created for the files that are in it).

I tried a quick and dirty fix for the zipfile _extract_member method, which basically should fix the problem!

So here I create the directory only if it is not already existing, to get those empty directories created inside the zip.

zipfile:
959: if member.filename[-1] == '/':
<add> if not os.path.isdir(targetpath):
960: os.mkdir(targetpath)

[ysjray]

I didn't see this problem in py2.7 and py3k on debian linux. Is this windows specific or this bug has been fixed since py2.7?

[terytkon]

Hi!

I haven't tested this in linux or with python 2.7 so can't say for sure..

However I would assume that the main issue is with the zipdate it self (So does it have those empty directories, which at least winzip creates) and then about how does the os.mkdir act with when trying to create already existing folder.

Did you try it with the example_1.zip, which has those folders described in the zip centralrecord??

Should I also try it out with linux?

-Teemu

[ysjray]

I found that this issue is duplicate with bpo-6050. And the bug has been fixed since 2.6.3.

So this issue should be closed.

[BreamoreBoy]

Closed as duplicate of bpo-6050.