Minor fix in test_file2k.OtherFileTests.testOpenDir

[ocean-city]

BPO	9287
Nosy	@pitrou, @giampaolo, @merwok, @voidspace
Files	test_file.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2010-09-23.15:59:52.626>
created_at = <Date 2010-07-17.14:39:02.614>
labels = ['easy', 'tests']
title = 'Minor fix in test_file2k.OtherFileTests.testOpenDir'
updated_at = <Date 2010-09-23.15:59:52.593>
user = 'https://bugs.python.org/ocean-city'

bugs.python.org fields:

activity = <Date 2010-09-23.15:59:52.593>
actor = 'ocean-city'
assignee = 'none'
closed = True
closed_date = <Date 2010-09-23.15:59:52.626>
closer = 'ocean-city'
components = ['Tests']
creation = <Date 2010-07-17.14:39:02.614>
creator = 'ocean-city'
dependencies = []
files = ['18040']
hgrepos = []
issue_num = 9287
keywords = ['patch', 'easy']
message_count = 5.0
messages = ['110563', '110564', '115041', '115042', '117203']
nosy_count = 5.0
nosy_names = ['pitrou', 'ocean-city', 'giampaolo.rodola', 'eric.araujo', 'michael.foord']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue9287'
versions = ['Python 2.7']

[ocean-city]

Hello. In OtherFileTests.testOpenDir(test_file), if we run this test
in Lib/test, __file__ becomes "test_file.py", so os.path.dirname(file) becomes "". I think it is better to use os.path.abspath to get valid folder path for test purpose.

# This test seems not to exist in Python2.7.

[merwok]

Thanks for the report. I have had exceptions in distutils2 tests because of this exact same thing; my fix was to use “os.path.dirname(file) or os.curdir”. I’ll change that if people more knowledgeable than me say your fix is better :)

[merwok]

This fell out of my radar, sorry. 2.6 is in security mode now, so this won’t be fixed.

I’m adding people listed in the “testing” interest area in Misc/maintainers.rst in case someone has an answer to my question.

[merwok]

Wait, the test with the small brokenness still exists in 2.7, it’s been renamed (see new bug title).

[ocean-city]

I've committed your fix in r84975. Thank you.