Dead code in Objects/object.c

[pitrou]

BPO	9294
Nosy	@pitrou
Files	internal_print_remove.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2010-07-27.22:10:44.687>
created_at = <Date 2010-07-18.14:55:42.721>
labels = ['interpreter-core', 'easy']
title = 'Dead code in Objects/object.c'
updated_at = <Date 2010-07-27.22:10:44.685>
user = 'https://github.com/pitrou'

bugs.python.org fields:

activity = <Date 2010-07-27.22:10:44.685>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2010-07-27.22:10:44.687>
closer = 'pitrou'
components = ['Interpreter Core']
creation = <Date 2010-07-18.14:55:42.721>
creator = 'pitrou'
dependencies = []
files = ['18201']
hgrepos = []
issue_num = 9294
keywords = ['patch', 'easy']
message_count = 4.0
messages = ['110651', '111564', '111572', '111734']
nosy_count = 2.0
nosy_names = ['pitrou', 'glimberg']
pr_nums = []
priority = 'low'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue9294'
versions = ['Python 3.1', 'Python 3.2']

[pitrou]

internal_print() is called from only one place, with the nesting argument wired to 0, therefore the following chunk of code in internal_print() never gets a chance to be executed:

    if (nesting > 10) {
        PyErr_SetString(PyExc_RuntimeError, "print recursion");
        return -1;
    }

[glimberg]

It looks like at one point, internal_print was a recursive function, but this is no longer the case. I've updated the function parameters to no longer contain the "nesting" parameter and removed the if block shown in this case.

[glimberg]

On second thought, internal_print() doesn't look like it's needed anymore as it's only called by PyObject_Print() and is no longer recursive. This second patch moves internal_print()'s function body into PyObject_Print and removes the internal_print function.

[pitrou]

Thank you! The patch was committed in r83184 (py3k) and r83185 (3.1).