Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffered IO shouldn't ignore incoming signals during a partial write #53826

Closed
pitrou opened this issue Aug 15, 2010 · 3 comments
Closed

Buffered IO shouldn't ignore incoming signals during a partial write #53826

pitrou opened this issue Aug 15, 2010 · 3 comments
Labels
topic-IO type-bug An unexpected behavior, bug, or error

Comments

@pitrou
Copy link
Member

pitrou commented Aug 15, 2010

BPO 9617
Nosy @loewis, @pitrou, @rnk
Files
  • sigbufio.patch
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2010-08-21.19:18:53.367>
    created_at = <Date 2010-08-15.21:28:26.992>
    labels = ['type-bug', 'expert-IO']
    title = "Buffered IO shouldn't ignore incoming signals during a partial write"
    updated_at = <Date 2010-08-21.19:18:53.366>
    user = 'https://github.com/pitrou'

    bugs.python.org fields:

    activity = <Date 2010-08-21.19:18:53.366>
    actor = 'pitrou'
    assignee = 'none'
    closed = True
    closed_date = <Date 2010-08-21.19:18:53.367>
    closer = 'pitrou'
    components = ['IO']
    creation = <Date 2010-08-15.21:28:26.992>
    creator = 'pitrou'
    dependencies = []
    files = ['18540']
    hgrepos = []
    issue_num = 9617
    keywords = ['patch']
    message_count = 3.0
    messages = ['114012', '114014', '114550']
    nosy_count = 4.0
    nosy_names = ['loewis', 'exarkun', 'pitrou', 'rnk']
    pr_nums = []
    priority = 'normal'
    resolution = 'fixed'
    stage = 'resolved'
    status = 'closed'
    superseder = None
    type = 'behavior'
    url = 'https://bugs.python.org/issue9617'
    versions = ['Python 3.1', 'Python 2.7', 'Python 3.2']

    @pitrou
    Copy link
    Member Author

    pitrou commented Aug 15, 2010

    Prompted by Martin in bpo-9611, here is a patch fixing the new buffered IO layer so that an incoming signal during a successful partial write() doesn't get ignored. Tests included.

    @pitrou pitrou added topic-IO type-bug An unexpected behavior, bug, or error labels Aug 15, 2010
    @pitrou
    Copy link
    Member Author

    pitrou commented Aug 15, 2010

    Another possibility is to do the check in the FileIO object instead. Both approaches give the same results for standard file descriptor IO.

    @pitrou
    Copy link
    Member Author

    pitrou commented Aug 21, 2010

    Issue fixed in r84239 (trunk), r84240 (2.7) and r84241 (3.1).

    @pitrou pitrou closed this as completed Aug 21, 2010
    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    topic-IO type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    1 participant