test_distutils should honor PYTHONDONTWRITEBYTECODE

[donmez]

BPO	9831
Nosy	@tarekziade, @ned-deily, @merwok

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/merwok'
closed_at = <Date 2011-05-29.16:18:58.977>
created_at = <Date 2010-09-11.09:46:18.975>
labels = ['OS-mac', 'tests', 'type-bug', 'library']
title = 'test_distutils should honor PYTHONDONTWRITEBYTECODE'
updated_at = <Date 2011-11-12.15:14:48.855>
user = 'https://bugs.python.org/donmez'

bugs.python.org fields:

activity = <Date 2011-11-12.15:14:48.855>
actor = 'eric.araujo'
assignee = 'eric.araujo'
closed = True
closed_date = <Date 2011-05-29.16:18:58.977>
closer = 'eric.araujo'
components = ['Distutils', 'macOS', 'Tests', 'Distutils2']
creation = <Date 2010-09-11.09:46:18.975>
creator = 'donmez'
dependencies = []
files = []
hgrepos = []
issue_num = 9831
keywords = []
message_count = 11.0
messages = ['116084', '116100', '116148', '116157', '116159', '116246', '137188', '137190', '137192', '137193', '147498']
nosy_count = 5.0
nosy_names = ['donmez', 'tarek', 'ned.deily', 'eric.araujo', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue9831'
versions = ['3rd party', 'Python 3.1', 'Python 2.7', 'Python 3.2', 'Python 3.3']

[donmez]

Using py3k branch revision 84707, on Mac OSX 10.6, case-sensitive HFS+ filesystem.

======================================================================
FAIL: test_package_data (distutils.tests.test_build_py.BuildPyTestCase)
----------------------------------------------------------------------

Traceback (most recent call last):
  File "/Users/cartman/Sources/py3k/Lib/distutils/tests/test_build_py.py", line 56, in test_package_data
    self.assertTrue("__init__.pyc" in files)
AssertionError: False is not True

[donmez]

Btw I configure with;

./configure --with-wctype-functions --with-fpectl --with-wide-unicode --with-computed-gotos --enable-ipv6 --with-universal-archs=64-bit MACOSX_DEPLOYMENT_TARGET=10.6

[merwok]

Thank you for the report. Can you apply this change and paste the new, more useful output?

• self.assertTrue("__init__.pyc" in files)
  + self.assertIn("__init__.pyc", files)

[ned-deily]

I am not able to reproduce that failure running on 10.6 (case-sensitive HFS+) using your ./configure options and running the tests in the build directory (make test). How are you running the tests? Could there be a file or directory permissions issue?

[donmez]

Problem is I set PYTHONDONTWRITEBYTECODE to 1, tests should disable this environmental variable before testing for *.pyc files. Closing as invalid.

[merwok]

I noticed this bug in the tests of distutils2 and added it to my todo list some time ago. Tests looking at pycs should take PYTHONDONTWRITEBYTECODE into account and be skipped instead of failing. I’ll fix it.

[python-dev]

New changeset da7617248935 by Éric Araujo in branch '2.7':
Fix test_distutils when sys.dont_write_bytecode is true (bpo-9831).
http://hg.python.org/cpython/rev/da7617248935

[python-dev]

New changeset 3d56e559ffc6 by Éric Araujo in branch '3.1':
Fix test_build_py when sys.dont_write_bytecode is true (bpo-9831).
http://hg.python.org/cpython/rev/3d56e559ffc6

New changeset 1370dc2690a2 by Éric Araujo in branch '3.2':
Merge doc touch-ups and fixes for bpo-9831 and bpo-9223 from 3.1
http://hg.python.org/cpython/rev/1370dc2690a2

New changeset c5d6a384132d by Éric Araujo in branch 'default':
Merge touch-ups and fixes for bpo-9831 (+port fix to packaging) and bpo-9223 from 3.2
http://hg.python.org/cpython/rev/c5d6a384132d

[merwok]

Now fixed, thanks for the report.

[donmez]

Awesome, thank you!

[merwok]

I now think the change I did was wrong. See bpo-12119.