Incorrect use of flowinfo and scope_id in IPv6 sockaddr tuple

[vnebehaj]

BPO	9975
Nosy	@loewis, @giampaolo
Files	python_flowinfo.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2012-01-03.16:51:56.745>
created_at = <Date 2010-09-28.18:35:44.649>
labels = ['type-bug', 'library']
title = 'Incorrect use of flowinfo and scope_id in IPv6 sockaddr tuple'
updated_at = <Date 2012-01-03.16:51:56.743>
user = 'https://bugs.python.org/vnebehaj'

bugs.python.org fields:

activity = <Date 2012-01-03.16:51:56.743>
actor = 'neologix'
assignee = 'none'
closed = True
closed_date = <Date 2012-01-03.16:51:56.745>
closer = 'neologix'
components = ['Library (Lib)']
creation = <Date 2010-09-28.18:35:44.649>
creator = 'vnebehaj'
dependencies = []
files = ['19049']
hgrepos = []
issue_num = 9975
keywords = ['patch']
message_count = 3.0
messages = ['117540', '150457', '150515']
nosy_count = 6.0
nosy_names = ['loewis', 'exarkun', 'giampaolo.rodola', 'neologix', 'vnebehaj', 'python-dev']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue9975'
versions = ['Python 3.1', 'Python 2.7', 'Python 3.2']

[vnebehaj]

Module/socketmodule.c incorrectly treats both sockaddr_in6->sin6_flowinfo and sockaddr_in6->sin6_scope_id as signed integers. They are 32-bit unsigned integers (even though sin6_flowinfo is just 20 bits).

sin6_flowinfo also lacks the necessary endian conversions when an IPv6 sockaddr tuple is parsed or returned. This makes it difficult to deal with sockets using sin6_flowinfo and deviates from RFCs. With the use of a signed int it also makes impossible to use flowinfo values that are larger than 2^31 if converted to little endian byte order (socketmodule.c raising an overflow exception).

sin6_scope_id has meaning only on the local machine (as an interface index), thus no endian conversion is needed for it.

[python-dev]

New changeset 0c10061df711 by Charles-François Natali in branch '2.7':
Issue bpo-9975: socket: Fix incorrect use of flowinfo and scope_id. Patch by
http://hg.python.org/cpython/rev/0c10061df711

New changeset cc346a672091 by Charles-François Natali in branch '3.2':
Issue bpo-9975: socket: Fix incorrect use of flowinfo and scope_id. Patch by
http://hg.python.org/cpython/rev/cc346a672091

New changeset 9222b8e7a7bc by Charles-François Natali in branch 'default':
Issue bpo-9975: socket: Fix incorrect use of flowinfo and scope_id. Patch by
http://hg.python.org/cpython/rev/9222b8e7a7bc

[neologix]

Should be fixed now.
Vilmos, thanks for the patch!