Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch to IDLE for Python 2.7, at Guido's request #54346

Closed
BruceSherwood mannequin opened this issue Oct 18, 2010 · 6 comments
Closed

Patch to IDLE for Python 2.7, at Guido's request #54346

BruceSherwood mannequin opened this issue Oct 18, 2010 · 6 comments
Labels
topic-IDLE type-bug An unexpected behavior, bug, or error

Comments

@BruceSherwood
Copy link
Mannequin

BruceSherwood mannequin commented Oct 18, 2010

BPO 10137
Nosy @terryjreedy, @kbkaiser, @amauryfa, @taleinat, @ned-deily
Superseder
  • bpo-10079: idlelib for Python 3 with Guilherme Polo GSoC enhancements
  • Files
  • idlelib2.7.patch: patch IDLE 2.7 to address problems
  • Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
    closed_at = <Date 2010-10-19.04:29:26.896>
    created_at = <Date 2010-10-18.15:54:04.316>
    labels = ['expert-IDLE', 'type-bug']
    title = "Patch to IDLE for Python 2.7, at Guido's request"
    updated_at = <Date 2010-10-19.04:29:26.895>
    user = 'https://bugs.python.org/BruceSherwood'

    bugs.python.org fields:

    activity = <Date 2010-10-19.04:29:26.895>
    actor = 'terry.reedy'
    assignee = 'none'
    closed = True
    closed_date = <Date 2010-10-19.04:29:26.896>
    closer = 'terry.reedy'
    components = ['IDLE']
    creation = <Date 2010-10-18.15:54:04.316>
    creator = 'Bruce.Sherwood'
    dependencies = []
    files = ['19263']
    hgrepos = []
    issue_num = 10137
    keywords = ['patch']
    message_count = 6.0
    messages = ['119033', '119046', '119063', '119075', '119095', '119117']
    nosy_count = 6.0
    nosy_names = ['terry.reedy', 'kbk', 'amaury.forgeotdarc', 'taleinat', 'ned.deily', 'Bruce.Sherwood']
    pr_nums = []
    priority = 'normal'
    resolution = 'duplicate'
    stage = None
    status = 'closed'
    superseder = '10079'
    type = 'behavior'
    url = 'https://bugs.python.org/issue10137'
    versions = ['Python 2.7']

    @BruceSherwood
    Copy link
    Mannequin Author

    BruceSherwood mannequin commented Oct 18, 2010

    At Guido's request, I've carried out the same update to the IDLE
    distributed with Python 2.7 that I submitted for Python 3, to incorporate the work of Guilherme Polo in the Google Summer of Code 2009. Guido was concerned that with significant problems reported for IDLE 2.7, there should be an update despite Python 2.7 itself being essentially frozen. The basic structure for IDLE 3.2 was carried over. The main changes that had to be made were the change in module names between Python 2.7 and Python 3.2 (e.g. Tkinter in 2.7 is tkinter in 3.2).

    @BruceSherwood BruceSherwood mannequin added topic-IDLE type-bug An unexpected behavior, bug, or error labels Oct 18, 2010
    @amauryfa
    Copy link
    Member

    But this patch is a diff between a 2.7 and a 3.2 version of IDLE, isn't it? The tkinter->Tkinter renaming is not supposed to happen in the 2.7 branch.
    Could you instead show a diff between the present version of IDLE in 2.7 and the result of your work, so we can better see the impact of the change?

    @ned-deily
    Copy link
    Member

    I believe the enhancements here are the same as submitted for py3k in bpo-10079. Since it is likely the same comments will apply to both variants, I think it would be better to have just one issue, so I would recommend regenerating the patch against the current 2.7 svn top of trunk (or the 2.7 release), attaching the patch to bpo-10079, and closing this as a duplicate.

    @terryjreedy
    Copy link
    Member

    Bruce, what Ned suggests is what I intended with my IDLE-list message, and in accord with usual tracker practice. Issues often apply to multiple versions and thereby require multiple patches and commits. I know you are relatively new at this and very much appreciate you pushing this IDLE update.

    @BruceSherwood
    Copy link
    Mannequin Author

    BruceSherwood mannequin commented Oct 18, 2010

    Perhaps I've used misleadingt terminology. What I meant is that I did
    do a diff between IDLE 2.7 and the result of Guilherme Polo's work,
    but the latter code started from Python 3 code and was modified as
    needed for 2.7 (e.g. renaming tkinter as Tkinter, etc.) before
    generating the patch.

    Bruce Sherwood

    On Mon, Oct 18, 2010 at 11:44 AM, Amaury Forgeot d'Arc
    <report@bugs.python.org> wrote:

    Amaury Forgeot d'Arc <amauryfa@gmail.com> added the comment:

    But this patch is a diff between a 2.7 and a 3.2 version of IDLE, isn't it?  The tkinter->Tkinter renaming is not supposed to happen in the 2.7 branch.
    Could you instead show a diff between the present version of IDLE in 2.7 and the result of your work, so we can better see the impact of the change?

    ----------
    nosy: +amaury.forgeotdarc


    Python tracker <report@bugs.python.org>
    <http://bugs.python.org/issue10137\>


    @BruceSherwood
    Copy link
    Mannequin Author

    BruceSherwood mannequin commented Oct 19, 2010

    I've rebuilt and resubmitted this patch to bpo-10079 as requested by Ned Deily. This issue (10137) can now be labeled a duplicate.

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    topic-IDLE type-bug An unexpected behavior, bug, or error
    Projects
    None yet
    Development

    No branches or pull requests

    3 participants