mimetypes read_windows_registry should tolerate permissions errors

[bobince]

BPO	10162
Nosy	@tjguk, @bobince, @briancurtin
Files	mimetypes-patch-3.2a3.patch: Ignore permissions errors, patch for mimetypes in py3k branch mimetypes-patch-2.7.patch: Ignore permissions errors, patch for mimetypes in release27-maint branch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/briancurtin'
closed_at = <Date 2010-10-21.14:50:06.832>
created_at = <Date 2010-10-21.00:44:35.805>
labels = ['type-bug', 'library', 'OS-windows']
title = 'mimetypes read_windows_registry should tolerate permissions errors'
updated_at = <Date 2010-10-21.14:50:06.831>
user = 'https://github.com/bobince'

bugs.python.org fields:

activity = <Date 2010-10-21.14:50:06.831>
actor = 'brian.curtin'
assignee = 'brian.curtin'
closed = True
closed_date = <Date 2010-10-21.14:50:06.832>
closer = 'brian.curtin'
components = ['Library (Lib)', 'Windows']
creation = <Date 2010-10-21.00:44:35.805>
creator = 'aclover'
dependencies = []
files = ['19314', '19315']
hgrepos = []
issue_num = 10162
keywords = ['patch']
message_count = 4.0
messages = ['119252', '119253', '119267', '119306']
nosy_count = 3.0
nosy_names = ['tim.golden', 'aclover', 'brian.curtin']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'behavior'
url = 'https://bugs.python.org/issue10162'
versions = ['Python 2.7', 'Python 3.2']

[bobince]

It is relatively common to have keys in the HKEY_CLASSES_ROOT MIME database that are not readable to all users, typically written by third-party applications. (My WinXP test box has a dozen, for apps like Flash, Silverlight and Java.)

Currently, initialising mimetypes causes Python to try to read them all, and if the user running Python doesn't have permission to read a key (in particular, if the user is a low-privilege daemon user such as IUSR_...), the script that caused mimetypes to be called will error out.

This patch moves the try-block around the call to OpenKey as well as QueryValueEx, allowing the key to be skipped if unreadable.

[bobince]

(same against 2.7 branch)

[tjguk]

I've only read the patch and not applied it, yet. But in principle I'm
+1 on this. If Brian doesn't get there first, I'll try to apply later.

[briancurtin]

Fixed in py3k (r85774, minor correction in r85775), and release27-maint (r85776).

Thanks for the patches!