Fix fd leak in sunau

[bbrazil]

BPO	10265
Nosy	@pitrou, @briancurtin
Files	sunau_fd_leak.patch sunau_fd_leak_v2.patch

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = None
closed_at = <Date 2010-10-31.21:27:21.510>
created_at = <Date 2010-10-31.15:03:31.796>
labels = ['library', 'performance']
title = 'Fix fd leak in sunau'
updated_at = <Date 2010-10-31.21:27:21.508>
user = 'https://bugs.python.org/bbrazil'

bugs.python.org fields:

activity = <Date 2010-10-31.21:27:21.508>
actor = 'pitrou'
assignee = 'none'
closed = True
closed_date = <Date 2010-10-31.21:27:21.510>
closer = 'pitrou'
components = ['Library (Lib)']
creation = <Date 2010-10-31.15:03:31.796>
creator = 'bbrazil'
dependencies = []
files = ['19446', '19447']
hgrepos = []
issue_num = 10265
keywords = ['patch']
message_count = 6.0
messages = ['120049', '120051', '120056', '120061', '120066', '120087']
nosy_count = 3.0
nosy_names = ['pitrou', 'brian.curtin', 'bbrazil']
pr_nums = []
priority = 'normal'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'resource usage'
url = 'https://bugs.python.org/issue10265'
versions = ['Python 3.2']

[bbrazil]

Please see attached.

It's possible that this change will lead to fds leaking if someone is passing in a fd, however a) this is consistent with how other modules (e.g. uu) do it and b) of the 2 (!) uses of this module I found on Google Codesearch, both pass in filenames.

[briancurtin]

Forget the attachment?

[bbrazil]

That'd help alright.

[pitrou]

It's possible that this change will lead to fds leaking if someone is
passing in a fd

I don't think so, why do you say that?

That said, there's an indentation problem in your patch.

[bbrazil]

Currently, if you pass in a fd it'll be closed by the __del__. My patch no longer does this so any use of the module depending on this behaviour could leak an fd. However, noone seems to use the module that way.

V2 attached.

[pitrou]

Committed in r86067. Thank you Brian!