make_buildinfo regression with unquoted path

[bz2]

BPO	10501
Nosy	@loewis, @kristjanvalur, @bz2, @iritkatriel
Files	issue9981_regression.patch: Patch sprinkling quotes around the place

^{Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.}

Show more details

GitHub fields:

assignee = 'https://github.com/kristjanvalur'
closed_at = <Date 2021-09-09.21:59:07.893>
created_at = <Date 2010-11-22.10:01:41.621>
labels = ['build']
title = 'make_buildinfo regression with unquoted path'
updated_at = <Date 2021-09-09.21:59:07.891>
user = 'https://github.com/bz2'

bugs.python.org fields:

activity = <Date 2021-09-09.21:59:07.891>
actor = 'iritkatriel'
assignee = 'kristjan.jonsson'
closed = True
closed_date = <Date 2021-09-09.21:59:07.893>
closer = 'iritkatriel'
components = ['Build']
creation = <Date 2010-11-22.10:01:41.621>
creator = 'gz'
dependencies = []
files = ['19769']
hgrepos = []
issue_num = 10501
keywords = ['patch']
message_count = 7.0
messages = ['122104', '122109', '122113', '122172', '122185', '127255', '401523']
nosy_count = 4.0
nosy_names = ['loewis', 'kristjan.jonsson', 'gz', 'iritkatriel']
pr_nums = []
priority = 'normal'
resolution = 'out of date'
stage = 'resolved'
status = 'closed'
superseder = None
type = None
url = 'https://bugs.python.org/issue10501'
versions = ['Python 3.2']

[bz2]

My build got broken by the change for bpo-9981 in revision 86137. The problem is it adds $(IntDir) to various places in the vcproj file, including the command line arguments to make_buildinfo, and my svn checkout is under a dir with a space in.

Ideally it could just use a relative path, but just making sure it's quoted works too.

[loewis]

Kristjan, can you take a look?

[kristjanvalur]

Ah yes, spaces in filenames. One always forgets.
Fixed the make_buildinfo.c (quote whole string, not just part of it) and committed in revision 86689

[bz2]

Thanks. Don't actually need to quote the whole path, but what you've landed works for me.

[kristjanvalur]

I did various tests and quoting parts of the path seemed fragile, especially if the quote landed next to a backslash. This is dangerous ground :)

[elibendersky]

Please see bpo-11034

[iritkatriel]

There is no longer a make_buildinfo.c